github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-11-03 23:40:03 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #60446 from cblecker/no-dep-reviewer

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 59365, 60446, 60448, 55019, 60431). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove dep-reviewers

**What this PR does / why we need it**:
The dep-reviewers group seems to get assigned PRs early the the review process. However, most code changes should be reviewed in the importing part of the code base first, and then assigned to an approver after.

By removing the reviewers group, the approvers plugin will still suggest assigning to an approver, but won't assign for review when the PR is initially opened.

**Release note**:

```release-note
NONE
```
This commit is contained in:
Kubernetes Submit Queue
2018-02-27 10:50:38 -08:00
committed by GitHub
parent 249ecab74e b97b9530f0
commit 724a2f968c
14 changed files with 0 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Godeps/OWNERS generated
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

4
OWNERS_ALIASES
View File

@@ -225,10 +225,6 @@ aliases:
- piosz
- jsafrane
- jbeda
dep-reviewers:
- cblecker
- thockin
- sttts
dep-approvers:
- cblecker
- thockin

2
hack/godep-save.sh
View File

@@ -89,8 +89,6 @@ hack/update-godep-licenses.sh >/dev/null
kube::log::status "Creating OWNERS file"
rm -f "Godeps/OWNERS" "vendor/OWNERS"
cat <<__EOF__ > "Godeps/OWNERS"
reviewers:
- dep-reviewers
approvers:
- dep-approvers
__EOF__

2
staging/src/k8s.io/api/Godeps/OWNERS generated
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

2
staging/src/k8s.io/apiextensions-apiserver/Godeps/OWNERS generated
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

2
staging/src/k8s.io/apimachinery/Godeps/OWNERS generated
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

2
staging/src/k8s.io/apiserver/Godeps/OWNERS generated
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

2
staging/src/k8s.io/client-go/Godeps/OWNERS generated
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

2
staging/src/k8s.io/code-generator/Godeps/OWNERS generated
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

2
staging/src/k8s.io/kube-aggregator/Godeps/OWNERS generated
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

2
staging/src/k8s.io/metrics/Godeps/OWNERS generated
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

2
staging/src/k8s.io/sample-apiserver/Godeps/OWNERS generated
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

2
staging/src/k8s.io/sample-controller/Godeps/OWNERS generated
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers

2
vendor/OWNERS vendored
View File

@@ -1,4 +1,2 @@
reviewers:
- dep-reviewers
approvers:
- dep-approvers