From 72654d347c8ac1b78d771c0c12c8b512b61a1376 Mon Sep 17 00:00:00 2001 From: Maciej Szulik Date: Thu, 11 Feb 2016 16:16:11 +0100 Subject: [PATCH] Comment out calls to httptest.Server.Close() to work around https://github.com/golang/go/issues/12262 . See #19254 for more details. This change should be reverted when we upgrade to Go 1.6. --- plugin/pkg/auth/authenticator/token/oidc/oidc_test.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go b/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go index 348ae19b9e0..451c65abf19 100644 --- a/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go +++ b/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go @@ -218,7 +218,8 @@ func TestOIDCDiscoveryNoKeyEndpoint(t *testing.T) { t.Fatalf("Cannot load cert/key pair: %v", err) } srv.StartTLS() - defer srv.Close() + // TODO: Uncomment when fix #19254 + // defer srv.Close() op.pcfg = oidc.ProviderConfig{ Issuer: srv.URL, @@ -274,7 +275,8 @@ func TestOIDCDiscoverySecureConnection(t *testing.T) { t.Fatalf("Cannot load cert/key pair: %v", err) } tlsSrv.StartTLS() - defer tlsSrv.Close() + // TODO: Uncomment when fix #19254 + // defer tlsSrv.Close() op.pcfg = oidc.ProviderConfig{ Issuer: tlsSrv.URL, @@ -309,7 +311,8 @@ func TestOIDCAuthentication(t *testing.T) { t.Fatalf("Cannot load cert/key pair: %v", err) } srv.StartTLS() - defer srv.Close() + // TODO: Uncomment when fix #19254 + // defer srv.Close() op.pcfg = oidc.ProviderConfig{ Issuer: srv.URL,