Don't allow to tolerate flakes

We have zero flake policy for a long time now (> 1 year) https://github.com/kubernetes/community/pull/7538, however , there are some places that are still tolerating flakes and retrying 

Flakes does not help,  to the point that when we have to take a hard decision it creates more iuncertainty.

It does not matter how, we should be always able to deal with flakes:
- if the software or algorithm is racy, we need to work to make deterministic
- if is deterministic, the test must be deterministic
- if the test is determinist but it depends on the environment, then we work on making the environment deterministci
This commit is contained in:
Antonio Ojea 2024-11-20 16:40:03 +01:00 committed by GitHub
parent bf70d289fb
commit 7280d58f85
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -44,9 +44,6 @@ CLOUD_CONFIG=${CLOUD_CONFIG:-""}
# render them properly).
GINKGO_NO_COLOR=${GINKGO_NO_COLOR:-$(if [ -t 2 ]; then echo n; else echo y; fi)}
# If 'y', will rerun failed tests once to give them a second chance.
GINKGO_TOLERATE_FLAKES=${GINKGO_TOLERATE_FLAKES:-n}
# If set, the command executed will be:
# - `dlv exec` if set to "delve"
# - `gdb` if set to "gdb"
@ -155,12 +152,6 @@ if [[ "${GINKGO_UNTIL_IT_FAILS:-}" == true ]]; then
ginkgo_args+=("--until-it-fails=true")
fi
FLAKE_ATTEMPTS=1
if [[ "${GINKGO_TOLERATE_FLAKES}" == "y" ]]; then
FLAKE_ATTEMPTS=2
fi
ginkgo_args+=("--flake-attempts=${FLAKE_ATTEMPTS}")
if [[ "${GINKGO_SILENCE_SKIPS}" == "y" ]]; then
ginkgo_args+=("--silence-skips")
fi