Improve conversion to support multiple packages

OpenShift uses multiple API packages (types are split) which
Kube will also eventually have as we introduce more plugins.
These changes make the generators able to handle importing different
API object packages into a single generator function.
This commit is contained in:
Clayton Coleman 2015-06-17 15:48:27 -04:00
parent fa6ee98ddc
commit 732647ea97
5 changed files with 325 additions and 74 deletions

View File

@ -17,13 +17,16 @@ limitations under the License.
package main package main
import ( import (
"fmt"
"io" "io"
"os" "os"
"path"
"runtime" "runtime"
"github.com/GoogleCloudPlatform/kubernetes/pkg/api" "github.com/GoogleCloudPlatform/kubernetes/pkg/api"
_ "github.com/GoogleCloudPlatform/kubernetes/pkg/api/v1" _ "github.com/GoogleCloudPlatform/kubernetes/pkg/api/v1"
pkg_runtime "github.com/GoogleCloudPlatform/kubernetes/pkg/runtime" pkg_runtime "github.com/GoogleCloudPlatform/kubernetes/pkg/runtime"
"github.com/GoogleCloudPlatform/kubernetes/pkg/util"
"github.com/golang/glog" "github.com/golang/glog"
flag "github.com/spf13/pflag" flag "github.com/spf13/pflag"
@ -50,7 +53,9 @@ func main() {
funcOut = file funcOut = file
} }
generator := pkg_runtime.NewConversionGenerator(api.Scheme.Raw()) generator := pkg_runtime.NewConversionGenerator(api.Scheme.Raw(), path.Join("github.com/GoogleCloudPlatform/kubernetes/pkg/api", *version))
apiShort := generator.AddImport("github.com/GoogleCloudPlatform/kubernetes/pkg/api")
generator.AddImport("github.com/GoogleCloudPlatform/kubernetes/pkg/api/resource")
// TODO(wojtek-t): Change the overwrites to a flag. // TODO(wojtek-t): Change the overwrites to a flag.
generator.OverwritePackage(*version, "") generator.OverwritePackage(*version, "")
for _, knownType := range api.Scheme.KnownTypes(*version) { for _, knownType := range api.Scheme.KnownTypes(*version) {
@ -58,10 +63,14 @@ func main() {
glog.Errorf("error while generating conversion functions for %v: %v", knownType, err) glog.Errorf("error while generating conversion functions for %v: %v", knownType, err)
} }
} }
generator.RepackImports(util.NewStringSet())
if err := generator.WriteImports(funcOut); err != nil {
glog.Fatalf("error while writing imports: %v", err)
}
if err := generator.WriteConversionFunctions(funcOut); err != nil { if err := generator.WriteConversionFunctions(funcOut); err != nil {
glog.Fatalf("Error while writing conversion functions: %v", err) glog.Fatalf("Error while writing conversion functions: %v", err)
} }
if err := generator.RegisterConversionFunctions(funcOut); err != nil { if err := generator.RegisterConversionFunctions(funcOut, fmt.Sprintf("%s.Scheme", apiShort)); err != nil {
glog.Fatalf("Error while writing conversion functions: %v", err) glog.Fatalf("Error while writing conversion functions: %v", err)
} }
} }

View File

@ -19,12 +19,14 @@ package main
import ( import (
"io" "io"
"os" "os"
"path"
"runtime" "runtime"
"strings" "strings"
"github.com/GoogleCloudPlatform/kubernetes/pkg/api" "github.com/GoogleCloudPlatform/kubernetes/pkg/api"
_ "github.com/GoogleCloudPlatform/kubernetes/pkg/api/v1" _ "github.com/GoogleCloudPlatform/kubernetes/pkg/api/v1"
pkg_runtime "github.com/GoogleCloudPlatform/kubernetes/pkg/runtime" pkg_runtime "github.com/GoogleCloudPlatform/kubernetes/pkg/runtime"
"github.com/GoogleCloudPlatform/kubernetes/pkg/util"
"github.com/golang/glog" "github.com/golang/glog"
flag "github.com/spf13/pflag" flag "github.com/spf13/pflag"
@ -53,10 +55,14 @@ func main() {
} }
knownVersion := *version knownVersion := *version
registerTo := "api.Scheme"
if knownVersion == "api" { if knownVersion == "api" {
knownVersion = api.Scheme.Raw().InternalVersion knownVersion = api.Scheme.Raw().InternalVersion
registerTo = "Scheme"
} }
generator := pkg_runtime.NewDeepCopyGenerator(api.Scheme.Raw()) pkgPath := path.Join("github.com/GoogleCloudPlatform/kubernetes/pkg/api", knownVersion)
generator := pkg_runtime.NewDeepCopyGenerator(api.Scheme.Raw(), pkgPath, util.NewStringSet("github.com/GoogleCloudPlatform/kubernetes"))
generator.AddImport("github.com/GoogleCloudPlatform/kubernetes/pkg/api")
for _, overwrite := range strings.Split(*overwrites, ",") { for _, overwrite := range strings.Split(*overwrites, ",") {
vals := strings.Split(overwrite, "=") vals := strings.Split(overwrite, "=")
@ -67,13 +73,14 @@ func main() {
glog.Errorf("error while generating deep copy functions for %v: %v", knownType, err) glog.Errorf("error while generating deep copy functions for %v: %v", knownType, err)
} }
} }
if err := generator.WriteImports(funcOut, *version); err != nil { generator.RepackImports()
if err := generator.WriteImports(funcOut); err != nil {
glog.Fatalf("error while writing imports: %v", err) glog.Fatalf("error while writing imports: %v", err)
} }
if err := generator.WriteDeepCopyFunctions(funcOut); err != nil { if err := generator.WriteDeepCopyFunctions(funcOut); err != nil {
glog.Fatalf("error while writing deep copy functions: %v", err) glog.Fatalf("error while writing deep copy functions: %v", err)
} }
if err := generator.RegisterDeepCopyFunctions(funcOut, *version); err != nil { if err := generator.RegisterDeepCopyFunctions(funcOut, registerTo); err != nil {
glog.Fatalf("error while registering deep copy functions: %v", err) glog.Fatalf("error while registering deep copy functions: %v", err)
} }
} }

View File

@ -33,14 +33,6 @@ function generate_version() {
cat >> $TMPFILE <<EOF cat >> $TMPFILE <<EOF
package ${version} package ${version}
import (
"reflect"
"github.com/GoogleCloudPlatform/kubernetes/pkg/api"
"github.com/GoogleCloudPlatform/kubernetes/pkg/api/resource"
"github.com/GoogleCloudPlatform/kubernetes/pkg/conversion"
)
// AUTO-GENERATED FUNCTIONS START HERE // AUTO-GENERATED FUNCTIONS START HERE
EOF EOF

View File

@ -19,40 +19,69 @@ package runtime
import ( import (
"fmt" "fmt"
"io" "io"
"path"
"reflect" "reflect"
"sort" "sort"
"strings" "strings"
"github.com/GoogleCloudPlatform/kubernetes/pkg/conversion" "github.com/GoogleCloudPlatform/kubernetes/pkg/conversion"
"github.com/GoogleCloudPlatform/kubernetes/pkg/util"
) )
type ConversionGenerator interface { type ConversionGenerator interface {
GenerateConversionsForType(version string, reflection reflect.Type) error GenerateConversionsForType(version string, reflection reflect.Type) error
WriteConversionFunctions(w io.Writer) error WriteConversionFunctions(w io.Writer) error
RegisterConversionFunctions(w io.Writer) error RegisterConversionFunctions(w io.Writer, pkg string) error
AddImport(pkg string) string
RepackImports(exclude util.StringSet)
WriteImports(w io.Writer) error
OverwritePackage(pkg, overwrite string) OverwritePackage(pkg, overwrite string)
AssumePrivateConversions()
} }
func NewConversionGenerator(scheme *conversion.Scheme) ConversionGenerator { func NewConversionGenerator(scheme *conversion.Scheme, targetPkg string) ConversionGenerator {
return &conversionGenerator{ g := &conversionGenerator{
scheme: scheme, scheme: scheme,
targetPkg: targetPkg,
convertibles: make(map[reflect.Type]reflect.Type), convertibles: make(map[reflect.Type]reflect.Type),
pkgOverwrites: make(map[string]string), pkgOverwrites: make(map[string]string),
imports: make(map[string]string),
shortImports: make(map[string]string),
} }
g.targetPackage(targetPkg)
g.AddImport("reflect")
g.AddImport("github.com/GoogleCloudPlatform/kubernetes/pkg/conversion")
return g
} }
var complexTypes []reflect.Kind = []reflect.Kind{reflect.Map, reflect.Ptr, reflect.Slice, reflect.Interface, reflect.Struct} var complexTypes []reflect.Kind = []reflect.Kind{reflect.Map, reflect.Ptr, reflect.Slice, reflect.Interface, reflect.Struct}
type conversionGenerator struct { type conversionGenerator struct {
scheme *conversion.Scheme scheme *conversion.Scheme
targetPkg string
convertibles map[reflect.Type]reflect.Type convertibles map[reflect.Type]reflect.Type
// If pkgOverwrites is set for a given package name, that package name // If pkgOverwrites is set for a given package name, that package name
// will be replaced while writing conversion function. If empty, package // will be replaced while writing conversion function. If empty, package
// name will be omitted. // name will be omitted.
pkgOverwrites map[string]string pkgOverwrites map[string]string
// map of package names to shortname
imports map[string]string
// map of short names to package names
shortImports map[string]string
// A buffer that is used for storing lines that needs to be written. // A buffer that is used for storing lines that needs to be written.
linesToPrint []string linesToPrint []string
// if true, we assume conversions on the scheme are not available to us in the current package
assumePrivateConversions bool
}
func (g *conversionGenerator) AssumePrivateConversions() {
g.assumePrivateConversions = true
}
func (g *conversionGenerator) AddImport(pkg string) string {
return g.addImportByPath(pkg)
} }
func (g *conversionGenerator) GenerateConversionsForType(version string, reflection reflect.Type) error { func (g *conversionGenerator) GenerateConversionsForType(version string, reflection reflect.Type) error {
@ -94,6 +123,10 @@ func (g *conversionGenerator) generateConversionsBetween(inType, outType reflect
} }
return fmt.Errorf("cannot convert types of different kinds: %v %v", inType, outType) return fmt.Errorf("cannot convert types of different kinds: %v %v", inType, outType)
} }
g.addImportByPath(inType.PkgPath())
g.addImportByPath(outType.PkgPath())
// We should be able to generate conversions both sides. // We should be able to generate conversions both sides.
switch inType.Kind() { switch inType.Kind() {
case reflect.Map: case reflect.Map:
@ -155,11 +188,15 @@ func isComplexType(reflection reflect.Type) bool {
func (g *conversionGenerator) generateConversionsForMap(inType, outType reflect.Type) error { func (g *conversionGenerator) generateConversionsForMap(inType, outType reflect.Type) error {
inKey := inType.Key() inKey := inType.Key()
outKey := outType.Key() outKey := outType.Key()
g.addImportByPath(inKey.PkgPath())
g.addImportByPath(outKey.PkgPath())
if err := g.generateConversionsBetween(inKey, outKey); err != nil { if err := g.generateConversionsBetween(inKey, outKey); err != nil {
return err return err
} }
inValue := inType.Elem() inValue := inType.Elem()
outValue := outType.Elem() outValue := outType.Elem()
g.addImportByPath(inKey.PkgPath())
g.addImportByPath(outKey.PkgPath())
if err := g.generateConversionsBetween(inValue, outValue); err != nil { if err := g.generateConversionsBetween(inValue, outValue); err != nil {
return err return err
} }
@ -238,6 +275,54 @@ func (s byName) Swap(i, j int) {
s[i], s[j] = s[j], s[i] s[i], s[j] = s[j], s[i]
} }
func (g *conversionGenerator) targetPackage(pkg string) {
g.imports[pkg] = ""
g.shortImports[""] = pkg
}
func (g *conversionGenerator) RepackImports(exclude util.StringSet) {
var packages []string
for key := range g.imports {
packages = append(packages, key)
}
sort.Strings(packages)
g.imports = make(map[string]string)
g.shortImports = make(map[string]string)
g.targetPackage(g.targetPkg)
for _, pkg := range packages {
if !exclude.Has(pkg) {
g.addImportByPath(pkg)
}
}
}
func (g *conversionGenerator) WriteImports(w io.Writer) error {
var packages []string
for key := range g.imports {
packages = append(packages, key)
}
sort.Strings(packages)
buffer := newBuffer()
indent := 0
buffer.addLine("import (\n", indent)
for _, importPkg := range packages {
if len(importPkg) == 0 {
continue
}
if len(g.imports[importPkg]) == 0 {
continue
}
buffer.addLine(fmt.Sprintf("%s \"%s\"\n", g.imports[importPkg], importPkg), indent+1)
}
buffer.addLine(")\n", indent)
buffer.addLine("\n", indent)
if err := buffer.flushLines(w); err != nil {
return err
}
return nil
}
func (g *conversionGenerator) WriteConversionFunctions(w io.Writer) error { func (g *conversionGenerator) WriteConversionFunctions(w io.Writer) error {
// It's desired to print conversion functions always in the same order // It's desired to print conversion functions always in the same order
// (e.g. for better tracking of what has really been added). // (e.g. for better tracking of what has really been added).
@ -265,9 +350,9 @@ func (g *conversionGenerator) WriteConversionFunctions(w io.Writer) error {
return nil return nil
} }
func (g *conversionGenerator) writeRegisterHeader(b *buffer, indent int) { func (g *conversionGenerator) writeRegisterHeader(b *buffer, pkg string, indent int) {
b.addLine("func init() {\n", indent) b.addLine("func init() {\n", indent)
b.addLine("err := api.Scheme.AddGeneratedConversionFuncs(\n", indent+1) b.addLine(fmt.Sprintf("err := %s.AddGeneratedConversionFuncs(\n", pkg), indent+1)
} }
func (g *conversionGenerator) writeRegisterFooter(b *buffer, indent int) { func (g *conversionGenerator) writeRegisterFooter(b *buffer, indent int) {
@ -280,7 +365,7 @@ func (g *conversionGenerator) writeRegisterFooter(b *buffer, indent int) {
b.addLine("\n", indent) b.addLine("\n", indent)
} }
func (g *conversionGenerator) RegisterConversionFunctions(w io.Writer) error { func (g *conversionGenerator) RegisterConversionFunctions(w io.Writer, pkg string) error {
// Write conversion function names alphabetically ordered. // Write conversion function names alphabetically ordered.
var names []string var names []string
for inType, outType := range g.convertibles { for inType, outType := range g.convertibles {
@ -290,7 +375,7 @@ func (g *conversionGenerator) RegisterConversionFunctions(w io.Writer) error {
buffer := newBuffer() buffer := newBuffer()
indent := 0 indent := 0
g.writeRegisterHeader(buffer, indent) g.writeRegisterHeader(buffer, pkg, indent)
for _, name := range names { for _, name := range names {
buffer.addLine(fmt.Sprintf("%s,\n", name), indent+2) buffer.addLine(fmt.Sprintf("%s,\n", name), indent+2)
} }
@ -301,32 +386,74 @@ func (g *conversionGenerator) RegisterConversionFunctions(w io.Writer) error {
return nil return nil
} }
func (g *conversionGenerator) addImportByPath(pkg string) string {
if name, ok := g.imports[pkg]; ok {
return name
}
name := path.Base(pkg)
if _, ok := g.shortImports[name]; !ok {
g.imports[pkg] = name
g.shortImports[name] = pkg
return name
}
if dirname := path.Base(path.Dir(pkg)); len(dirname) > 0 {
name = dirname + name
if _, ok := g.shortImports[name]; !ok {
g.imports[pkg] = name
g.shortImports[name] = pkg
return name
}
if subdirname := path.Base(path.Dir(path.Dir(pkg))); len(subdirname) > 0 {
name = subdirname + name
if _, ok := g.shortImports[name]; !ok {
g.imports[pkg] = name
g.shortImports[name] = pkg
return name
}
}
}
for i := 2; i < 100; i++ {
generatedName := fmt.Sprintf("%s%d", name, i)
if _, ok := g.shortImports[generatedName]; !ok {
g.imports[pkg] = generatedName
g.shortImports[generatedName] = pkg
return generatedName
}
}
panic(fmt.Sprintf("unable to find a unique name for the package path %q: %v", pkg, g.shortImports))
}
func (g *conversionGenerator) typeName(inType reflect.Type) string { func (g *conversionGenerator) typeName(inType reflect.Type) string {
switch inType.Kind() { switch inType.Kind() {
case reflect.Map:
return fmt.Sprintf("map[%s]%s", g.typeName(inType.Key()), g.typeName(inType.Elem()))
case reflect.Slice: case reflect.Slice:
return fmt.Sprintf("[]%s", g.typeName(inType.Elem())) return fmt.Sprintf("[]%s", g.typeName(inType.Elem()))
case reflect.Ptr: case reflect.Ptr:
return fmt.Sprintf("*%s", g.typeName(inType.Elem())) return fmt.Sprintf("*%s", g.typeName(inType.Elem()))
default: case reflect.Map:
typeWithPkg := fmt.Sprintf("%s", inType) if len(inType.Name()) == 0 {
slices := strings.Split(typeWithPkg, ".") return fmt.Sprintf("map[%s]%s", g.typeName(inType.Key()), g.typeName(inType.Elem()))
if len(slices) == 1 { }
// Default package. fallthrough
return slices[0] default:
pkg, name := inType.PkgPath(), inType.Name()
if len(name) == 0 && inType.Kind() == reflect.Struct {
return "struct{}"
}
if len(pkg) == 0 {
// Default package.
return name
} }
if len(slices) == 2 {
pkg := slices[0]
if val, found := g.pkgOverwrites[pkg]; found { if val, found := g.pkgOverwrites[pkg]; found {
pkg = val pkg = val
} }
if pkg != "" { if len(pkg) == 0 {
pkg = pkg + "." return name
} }
return pkg + slices[1] short := g.addImportByPath(pkg)
if len(short) > 0 {
return fmt.Sprintf("%s.%s", short, name)
} }
panic("Incorrect type name: " + typeWithPkg) return name
} }
} }
@ -658,6 +785,10 @@ func (g *conversionGenerator) existsDedicatedConversionFunction(inType, outType
// unnamed. Thus we return false here. // unnamed. Thus we return false here.
return false return false
} }
// TODO: no way to handle private conversions in different packages
if g.assumePrivateConversions {
return false
}
return g.scheme.Converter().HasConversionFunc(inType, outType) return g.scheme.Converter().HasConversionFunc(inType, outType)
} }

View File

@ -19,6 +19,7 @@ package runtime
import ( import (
"fmt" "fmt"
"io" "io"
"path"
"reflect" "reflect"
"sort" "sort"
"strings" "strings"
@ -38,9 +39,20 @@ type DeepCopyGenerator interface {
// functions for this type and all nested types will be generated. // functions for this type and all nested types will be generated.
AddType(inType reflect.Type) error AddType(inType reflect.Type) error
// ReplaceType registers a type that should be used instead of the type
// with the provided pkgPath and name.
ReplaceType(pkgPath, name string, in interface{})
// AddImport registers a package name with the generator and returns its
// short name.
AddImport(pkgPath string) string
// RepackImports creates a stable ordering of import short names
RepackImports()
// Writes all imports that are necessary for deep-copy function and // Writes all imports that are necessary for deep-copy function and
// their registration. // their registration.
WriteImports(w io.Writer, pkg string) error WriteImports(w io.Writer) error
// Writes deel-copy functions for all types added via AddType() method // Writes deel-copy functions for all types added via AddType() method
// and their nested types. // and their nested types.
@ -57,20 +69,80 @@ type DeepCopyGenerator interface {
OverwritePackage(pkg, overwrite string) OverwritePackage(pkg, overwrite string)
} }
func NewDeepCopyGenerator(scheme *conversion.Scheme) DeepCopyGenerator { func NewDeepCopyGenerator(scheme *conversion.Scheme, targetPkg string, include util.StringSet) DeepCopyGenerator {
return &deepCopyGenerator{ g := &deepCopyGenerator{
scheme: scheme, scheme: scheme,
targetPkg: targetPkg,
copyables: make(map[reflect.Type]bool), copyables: make(map[reflect.Type]bool),
imports: util.StringSet{}, imports: make(map[string]string),
shortImports: make(map[string]string),
pkgOverwrites: make(map[string]string), pkgOverwrites: make(map[string]string),
replace: make(map[pkgPathNamePair]reflect.Type),
include: include,
} }
g.targetPackage(targetPkg)
g.AddImport("github.com/GoogleCloudPlatform/kubernetes/pkg/conversion")
return g
}
type pkgPathNamePair struct {
PkgPath string
Name string
} }
type deepCopyGenerator struct { type deepCopyGenerator struct {
scheme *conversion.Scheme scheme *conversion.Scheme
targetPkg string
copyables map[reflect.Type]bool copyables map[reflect.Type]bool
imports util.StringSet // map of package names to shortname
imports map[string]string
// map of short names to package names
shortImports map[string]string
pkgOverwrites map[string]string pkgOverwrites map[string]string
replace map[pkgPathNamePair]reflect.Type
include util.StringSet
}
func (g *deepCopyGenerator) addImportByPath(pkg string) string {
if name, ok := g.imports[pkg]; ok {
return name
}
name := path.Base(pkg)
if _, ok := g.shortImports[name]; !ok {
g.imports[pkg] = name
g.shortImports[name] = pkg
return name
}
if dirname := path.Base(path.Dir(pkg)); len(dirname) > 0 {
name = dirname + name
if _, ok := g.shortImports[name]; !ok {
g.imports[pkg] = name
g.shortImports[name] = pkg
return name
}
if subdirname := path.Base(path.Dir(path.Dir(pkg))); len(subdirname) > 0 {
name = subdirname + name
if _, ok := g.shortImports[name]; !ok {
g.imports[pkg] = name
g.shortImports[name] = pkg
return name
}
}
}
for i := 2; i < 100; i++ {
generatedName := fmt.Sprintf("%s%d", name, i)
if _, ok := g.shortImports[generatedName]; !ok {
g.imports[pkg] = generatedName
g.shortImports[generatedName] = pkg
return generatedName
}
}
panic(fmt.Sprintf("unable to find a unique name for the package path %q: %v", pkg, g.shortImports))
}
func (g *deepCopyGenerator) targetPackage(pkg string) {
g.imports[pkg] = ""
g.shortImports[""] = pkg
} }
func (g *deepCopyGenerator) addAllRecursiveTypes(inType reflect.Type) error { func (g *deepCopyGenerator) addAllRecursiveTypes(inType reflect.Type) error {
@ -90,11 +162,18 @@ func (g *deepCopyGenerator) addAllRecursiveTypes(inType reflect.Type) error {
return err return err
} }
case reflect.Interface: case reflect.Interface:
g.imports.Insert(inType.PkgPath()) g.addImportByPath(inType.PkgPath())
return nil return nil
case reflect.Struct: case reflect.Struct:
g.imports.Insert(inType.PkgPath()) g.addImportByPath(inType.PkgPath())
if !strings.HasPrefix(inType.PkgPath(), "github.com/GoogleCloudPlatform/kubernetes") { found := false
for s := range g.include {
if strings.HasPrefix(inType.PkgPath(), s) {
found = true
break
}
}
if !found {
return nil return nil
} }
for i := 0; i < inType.NumField(); i++ { for i := 0; i < inType.NumField(); i++ {
@ -110,6 +189,15 @@ func (g *deepCopyGenerator) addAllRecursiveTypes(inType reflect.Type) error {
return nil return nil
} }
func (g *deepCopyGenerator) AddImport(pkg string) string {
return g.addImportByPath(pkg)
}
// ReplaceType registers a replacement type to be used instead of the named type
func (g *deepCopyGenerator) ReplaceType(pkgPath, name string, t interface{}) {
g.replace[pkgPathNamePair{pkgPath, name}] = reflect.TypeOf(t)
}
func (g *deepCopyGenerator) AddType(inType reflect.Type) error { func (g *deepCopyGenerator) AddType(inType reflect.Type) error {
if inType.Kind() != reflect.Struct { if inType.Kind() != reflect.Struct {
return fmt.Errorf("non-struct copies are not supported") return fmt.Errorf("non-struct copies are not supported")
@ -117,10 +205,23 @@ func (g *deepCopyGenerator) AddType(inType reflect.Type) error {
return g.addAllRecursiveTypes(inType) return g.addAllRecursiveTypes(inType)
} }
func (g *deepCopyGenerator) WriteImports(w io.Writer, pkg string) error { func (g *deepCopyGenerator) RepackImports() {
var packages []string
for key := range g.imports {
packages = append(packages, key)
}
sort.Strings(packages)
g.imports = make(map[string]string)
g.shortImports = make(map[string]string)
g.targetPackage(g.targetPkg)
for _, pkg := range packages {
g.addImportByPath(pkg)
}
}
func (g *deepCopyGenerator) WriteImports(w io.Writer) error {
var packages []string var packages []string
packages = append(packages, "github.com/GoogleCloudPlatform/kubernetes/pkg/api")
packages = append(packages, "github.com/GoogleCloudPlatform/kubernetes/pkg/conversion")
for key := range g.imports { for key := range g.imports {
packages = append(packages, key) packages = append(packages, key)
} }
@ -130,10 +231,13 @@ func (g *deepCopyGenerator) WriteImports(w io.Writer, pkg string) error {
indent := 0 indent := 0
buffer.addLine("import (\n", indent) buffer.addLine("import (\n", indent)
for _, importPkg := range packages { for _, importPkg := range packages {
if strings.HasSuffix(importPkg, pkg) { if len(importPkg) == 0 {
continue continue
} }
buffer.addLine(fmt.Sprintf("\"%s\"\n", importPkg), indent+1) if len(g.imports[importPkg]) == 0 {
continue
}
buffer.addLine(fmt.Sprintf("%s \"%s\"\n", g.imports[importPkg], importPkg), indent+1)
} }
buffer.addLine(")\n", indent) buffer.addLine(")\n", indent)
buffer.addLine("\n", indent) buffer.addLine("\n", indent)
@ -159,35 +263,47 @@ func (s byPkgAndName) Swap(i, j int) {
s[i], s[j] = s[j], s[i] s[i], s[j] = s[j], s[i]
} }
func (g *deepCopyGenerator) typeName(inType reflect.Type) string { func (g *deepCopyGenerator) nameForType(inType reflect.Type) string {
switch inType.Kind() { switch inType.Kind() {
case reflect.Map:
return fmt.Sprintf("map[%s]%s", g.typeName(inType.Key()), g.typeName(inType.Elem()))
case reflect.Slice: case reflect.Slice:
return fmt.Sprintf("[]%s", g.typeName(inType.Elem())) return fmt.Sprintf("[]%s", g.typeName(inType.Elem()))
case reflect.Ptr: case reflect.Ptr:
return fmt.Sprintf("*%s", g.typeName(inType.Elem())) return fmt.Sprintf("*%s", g.typeName(inType.Elem()))
default: case reflect.Map:
typeWithPkg := fmt.Sprintf("%s", inType) if len(inType.Name()) == 0 {
slices := strings.Split(typeWithPkg, ".") return fmt.Sprintf("map[%s]%s", g.typeName(inType.Key()), g.typeName(inType.Elem()))
if len(slices) == 1 { }
// Default package. fallthrough
return slices[0] default:
pkg, name := inType.PkgPath(), inType.Name()
if len(name) == 0 && inType.Kind() == reflect.Struct {
return "struct{}"
}
if len(pkg) == 0 {
// Default package.
return name
} }
if len(slices) == 2 {
pkg := slices[0]
if val, found := g.pkgOverwrites[pkg]; found { if val, found := g.pkgOverwrites[pkg]; found {
pkg = val pkg = val
} }
if pkg != "" { if len(pkg) == 0 {
pkg = pkg + "." return name
} }
return pkg + slices[1] short := g.addImportByPath(pkg)
if len(short) > 0 {
return fmt.Sprintf("%s.%s", short, name)
} }
panic("Incorrect type name: " + typeWithPkg) return name
} }
} }
func (g *deepCopyGenerator) typeName(inType reflect.Type) string {
if t, ok := g.replace[pkgPathNamePair{inType.PkgPath(), inType.Name()}]; ok {
return g.nameForType(t)
}
return g.nameForType(inType)
}
func (g *deepCopyGenerator) deepCopyFunctionName(inType reflect.Type) string { func (g *deepCopyGenerator) deepCopyFunctionName(inType reflect.Type) string {
funcNameFormat := "deepCopy_%s_%s" funcNameFormat := "deepCopy_%s_%s"
inPkg := packageForName(inType) inPkg := packageForName(inType)
@ -442,12 +558,8 @@ func (g *deepCopyGenerator) writeDeepCopyForType(b *buffer, inType reflect.Type,
func (g *deepCopyGenerator) writeRegisterHeader(b *buffer, pkg string, indent int) { func (g *deepCopyGenerator) writeRegisterHeader(b *buffer, pkg string, indent int) {
b.addLine("func init() {\n", indent) b.addLine("func init() {\n", indent)
registerFormat := "err := %sScheme.AddGeneratedDeepCopyFuncs(\n" registerFormat := "err := %s.AddGeneratedDeepCopyFuncs(\n"
if pkg == "api" { b.addLine(fmt.Sprintf(registerFormat, pkg), indent+1)
b.addLine(fmt.Sprintf(registerFormat, ""), indent+1)
} else {
b.addLine(fmt.Sprintf(registerFormat, "api."), indent+1)
}
} }
func (g *deepCopyGenerator) writeRegisterFooter(b *buffer, indent int) { func (g *deepCopyGenerator) writeRegisterFooter(b *buffer, indent int) {