github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-27 05:27:21 +00:00
Code Issues Projects Releases Wiki Activity

Add deprecated stage of feature gates

Browse Source
This commit is contained in:
Jordan Liggitt 2018-01-26 10:44:41 -05:00
parent a73c96d7b2
commit 7336eeab8a
No known key found for this signature in database
GPG Key ID: 39928704103C7229
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
staging/src/k8s.io/apiserver/pkg/util/feature/feature_gate.go
View File

@ -67,6 +67,9 @@ const (
Alpha = prerelease("ALPHA") Alpha = prerelease("ALPHA")
Beta = prerelease("BETA") Beta = prerelease("BETA")
GA = prerelease("") GA = prerelease("")
// Deprecated
Deprecated = prerelease("DEPRECATED")
) )
// FeatureGate parses and stores flag gates for known features from // FeatureGate parses and stores flag gates for known features from
@ -157,7 +160,7 @@ func (f *featureGate) Set(value string) error {
} }
arr := strings.SplitN(s, "=", 2) arr := strings.SplitN(s, "=", 2)
k := Feature(strings.TrimSpace(arr[0])) k := Feature(strings.TrimSpace(arr[0]))
_, ok := known[k] featureSpec, ok := known[k]
if !ok { if !ok {
return fmt.Errorf("unrecognized key: %s", k) return fmt.Errorf("unrecognized key: %s", k)
} }
@ -170,6 +173,9 @@ func (f *featureGate) Set(value string) error {
return fmt.Errorf("invalid value of %s: %s, err: %v", k, v, err) return fmt.Errorf("invalid value of %s: %s, err: %v", k, v, err)
} }
enabled[k] = boolValue enabled[k] = boolValue
if boolValue && featureSpec.PreRelease == Deprecated {
glog.Warningf("enabling deprecated feature gate %s", k)
}
// Handle "special" features like "all alpha gates" // Handle "special" features like "all alpha gates"
if fn, found := f.special[k]; found { if fn, found := f.special[k]; found {