From f82fb4059d6a9e095e3f059683a09838f49a2ee5 Mon Sep 17 00:00:00 2001 From: SataQiu Date: Sat, 23 Mar 2019 12:20:49 +0800 Subject: [PATCH] fix some failures in pkg/apis --- hack/.golint_failures | 5 ----- pkg/apis/authentication/register.go | 4 +++- pkg/apis/coordination/register.go | 4 +++- pkg/apis/events/register.go | 4 +++- pkg/apis/imagepolicy/register.go | 4 +++- pkg/apis/settings/register.go | 4 +++- 6 files changed, 15 insertions(+), 10 deletions(-) diff --git a/hack/.golint_failures b/hack/.golint_failures index 59618617ac0..87b0e6b9a96 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -15,7 +15,6 @@ pkg/apis/apps/v1beta1 pkg/apis/apps/v1beta2 pkg/apis/apps/validation pkg/apis/auditregistration/v1alpha1 -pkg/apis/authentication pkg/apis/authentication/v1 pkg/apis/authorization pkg/apis/authorization/v1 @@ -33,7 +32,6 @@ pkg/apis/batch/validation pkg/apis/certificates pkg/apis/certificates/v1beta1 pkg/apis/certificates/validation -pkg/apis/coordination pkg/apis/core pkg/apis/core/helper pkg/apis/core/helper/qos @@ -42,11 +40,9 @@ pkg/apis/core/v1/helper pkg/apis/core/v1/helper/qos pkg/apis/core/v1/validation pkg/apis/core/validation -pkg/apis/events pkg/apis/events/v1beta1 pkg/apis/extensions pkg/apis/extensions/v1beta1 -pkg/apis/imagepolicy pkg/apis/networking pkg/apis/networking/v1 pkg/apis/node/v1alpha1 @@ -59,7 +55,6 @@ pkg/apis/rbac/v1alpha1 pkg/apis/rbac/v1beta1 pkg/apis/rbac/validation pkg/apis/scheduling -pkg/apis/settings pkg/apis/storage pkg/apis/storage/util pkg/apis/storage/v1 diff --git a/pkg/apis/authentication/register.go b/pkg/apis/authentication/register.go index 1174d5cce50..fdd77297290 100644 --- a/pkg/apis/authentication/register.go +++ b/pkg/apis/authentication/register.go @@ -38,8 +38,10 @@ func Resource(resource string) schema.GroupResource { } var ( + // SchemeBuilder points to a list of functions added to Scheme. SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes) - AddToScheme = SchemeBuilder.AddToScheme + // AddToScheme applies all the stored functions to the scheme. + AddToScheme = SchemeBuilder.AddToScheme ) func addKnownTypes(scheme *runtime.Scheme) error { diff --git a/pkg/apis/coordination/register.go b/pkg/apis/coordination/register.go index 9780ad16e88..5362c3aa735 100644 --- a/pkg/apis/coordination/register.go +++ b/pkg/apis/coordination/register.go @@ -38,8 +38,10 @@ func Resource(resource string) schema.GroupResource { } var ( + // SchemeBuilder points to a list of functions added to Scheme. SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes) - AddToScheme = SchemeBuilder.AddToScheme + // AddToScheme applies all the stored functions to the scheme. + AddToScheme = SchemeBuilder.AddToScheme ) // Adds the list of known types to the given scheme. diff --git a/pkg/apis/events/register.go b/pkg/apis/events/register.go index 6156e800688..4bd99c1a550 100644 --- a/pkg/apis/events/register.go +++ b/pkg/apis/events/register.go @@ -39,8 +39,10 @@ func Resource(resource string) schema.GroupResource { } var ( + // SchemeBuilder points to a list of functions added to Scheme. SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes) - AddToScheme = SchemeBuilder.AddToScheme + // AddToScheme applies all the stored functions to the scheme. + AddToScheme = SchemeBuilder.AddToScheme ) func addKnownTypes(scheme *runtime.Scheme) error { diff --git a/pkg/apis/imagepolicy/register.go b/pkg/apis/imagepolicy/register.go index 446aaf5ec89..67d42c375d5 100644 --- a/pkg/apis/imagepolicy/register.go +++ b/pkg/apis/imagepolicy/register.go @@ -38,8 +38,10 @@ func Resource(resource string) schema.GroupResource { } var ( + // SchemeBuilder points to a list of functions added to Scheme. SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes) - AddToScheme = SchemeBuilder.AddToScheme + // AddToScheme applies all the stored functions to the scheme. + AddToScheme = SchemeBuilder.AddToScheme ) func addKnownTypes(scheme *runtime.Scheme) error { diff --git a/pkg/apis/settings/register.go b/pkg/apis/settings/register.go index 7b144b7dfc8..893e3960504 100644 --- a/pkg/apis/settings/register.go +++ b/pkg/apis/settings/register.go @@ -22,8 +22,10 @@ import ( ) var ( + // SchemeBuilder points to a list of functions added to Scheme. SchemeBuilder = runtime.NewSchemeBuilder(addKnownTypes) - AddToScheme = SchemeBuilder.AddToScheme + // AddToScheme applies all the stored functions to the scheme. + AddToScheme = SchemeBuilder.AddToScheme ) // GroupName is the group name use in this package