diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures index 9904a898246..63ba8fb6ead 100644 --- a/hack/.shellcheck_failures +++ b/hack/.shellcheck_failures @@ -35,7 +35,6 @@ ./hack/jenkins/test-dockerized.sh ./hack/jenkins/upload-to-gcs.sh ./hack/jenkins/verify-dockerized.sh -./hack/lib/etcd.sh ./hack/lib/golang.sh ./hack/lib/init.sh ./hack/lib/logging.sh diff --git a/hack/lib/etcd.sh b/hack/lib/etcd.sh index 17f55810019..79821e7d9d7 100755 --- a/hack/lib/etcd.sh +++ b/hack/lib/etcd.sh @@ -41,18 +41,18 @@ kube::etcd::validate() { fi if ${port_check_command} -nat | grep "LISTEN" | grep "[\.:]${ETCD_PORT:?}" >/dev/null 2>&1; then kube::log::usage "unable to start etcd as port ${ETCD_PORT} is in use. please stop the process listening on this port and retry." - kube::log::usage "`netstat -nat | grep "[\.:]${ETCD_PORT:?} .*LISTEN"`" + kube::log::usage "$(netstat -nat | grep "[\.:]${ETCD_PORT:?} .*LISTEN")" exit 1 fi # validate installed version is at least equal to minimum version=$(etcd --version | tail -n +1 | head -n 1 | cut -d " " -f 3) - if [[ $(kube::etcd::version ${ETCD_VERSION}) -gt $(kube::etcd::version ${version}) ]]; then + if [[ $(kube::etcd::version "${ETCD_VERSION}") -gt $(kube::etcd::version "${version}") ]]; then export PATH=${KUBE_ROOT}/third_party/etcd:${PATH} hash etcd echo "${PATH}" version=$(etcd --version | head -n 1 | cut -d " " -f 3) - if [[ $(kube::etcd::version ${ETCD_VERSION}) -gt $(kube::etcd::version ${version}) ]]; then + if [[ $(kube::etcd::version "${ETCD_VERSION}") -gt $(kube::etcd::version "${version}") ]]; then kube::log::usage "etcd version ${ETCD_VERSION} or greater required." kube::log::info "You can use 'hack/install-etcd.sh' to install a copy in third_party/." exit 1 @@ -76,7 +76,7 @@ kube::etcd::start() { ETCD_LOGFILE=${ETCD_LOGFILE:-"/dev/null"} fi kube::log::info "etcd --advertise-client-urls ${KUBE_INTEGRATION_ETCD_URL} --data-dir ${ETCD_DIR} --listen-client-urls http://${ETCD_HOST}:${ETCD_PORT} --debug > \"${ETCD_LOGFILE}\" 2>/dev/null" - etcd --advertise-client-urls ${KUBE_INTEGRATION_ETCD_URL} --data-dir ${ETCD_DIR} --listen-client-urls ${KUBE_INTEGRATION_ETCD_URL} --debug 2> "${ETCD_LOGFILE}" >/dev/null & + etcd --advertise-client-urls "${KUBE_INTEGRATION_ETCD_URL}" --data-dir "${ETCD_DIR}" --listen-client-urls "${KUBE_INTEGRATION_ETCD_URL}" --debug 2> "${ETCD_LOGFILE}" >/dev/null & ETCD_PID=$! echo "Waiting for etcd to come up." @@ -110,7 +110,7 @@ kube::etcd::install() { os=$(kube::util::host_os) arch=$(kube::util::host_arch) - cd "${KUBE_ROOT}/third_party" + cd "${KUBE_ROOT}/third_party" || return 1 if [[ $(readlink etcd) == etcd-v${ETCD_VERSION}-${os}-* ]]; then kube::log::info "etcd v${ETCD_VERSION} already installed at path:" kube::log::info "$(pwd)/$(readlink etcd)"