github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 17:30:00 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #11914 from nikhiljindal/missingSwagger

Browse Source 
Swagger validation: stop ignoring unknown fields
This commit is contained in:
Mike Danese 2015-07-31 10:42:18 -07:00
commit 739fc1a572
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/api/validation/schema.go
View File

@ -114,7 +114,7 @@ func (s *SwaggerSchema) ValidateObject(obj interface{}, apiVersion, fieldName, t
if len(fieldName) > 0 { if len(fieldName) > 0 {
fieldName = fieldName + "." fieldName = fieldName + "."
} }
//handle required fields // handle required fields
for _, requiredKey := range model.Required { for _, requiredKey := range model.Required {
if _, ok := fields[requiredKey]; !ok { if _, ok := fields[requiredKey]; !ok {
allErrs = append(allErrs, fmt.Errorf("field %s: is required", requiredKey)) allErrs = append(allErrs, fmt.Errorf("field %s: is required", requiredKey))
@ -123,10 +123,7 @@ func (s *SwaggerSchema) ValidateObject(obj interface{}, apiVersion, fieldName, t
for key, value := range fields { for key, value := range fields {
details, ok := properties.At(key) details, ok := properties.At(key)
if !ok { if !ok {
glog.Infof("unknown field: %s", key) allErrs = append(allErrs, fmt.Errorf("found invalid field %s for %s", key, typeName))
// Some properties can be missing because of
// https://github.com/GoogleCloudPlatform/kubernetes/issues/6842.
glog.Info("this may be a false alarm, see https://github.com/GoogleCloudPlatform/kubernetes/issues/6842")
continue continue
} }
if details.Type == nil && details.Ref == nil { if details.Type == nil && details.Ref == nil {