diff --git a/pkg/kubectl/cmd/BUILD b/pkg/kubectl/cmd/BUILD index aabaeec1885..c2198c2973d 100644 --- a/pkg/kubectl/cmd/BUILD +++ b/pkg/kubectl/cmd/BUILD @@ -94,6 +94,7 @@ go_library( "//pkg/kubectl/plugins:go_default_library", "//pkg/kubectl/resource:go_default_library", "//pkg/kubectl/util:go_default_library", + "//pkg/kubectl/util/term:go_default_library", "//pkg/kubelet/types:go_default_library", "//pkg/printers:go_default_library", "//pkg/printers/internalversion:go_default_library", @@ -101,7 +102,6 @@ go_library( "//pkg/util/i18n:go_default_library", "//pkg/util/interrupt:go_default_library", "//pkg/util/taints:go_default_library", - "//pkg/util/term:go_default_library", "//pkg/version:go_default_library", "//vendor/github.com/daviddengcn/go-colortext:go_default_library", "//vendor/github.com/docker/distribution/reference:go_default_library", @@ -214,11 +214,11 @@ go_test( "//pkg/kubectl/cmd/util/openapi:go_default_library", "//pkg/kubectl/plugins:go_default_library", "//pkg/kubectl/resource:go_default_library", + "//pkg/kubectl/util/term:go_default_library", "//pkg/printers:go_default_library", "//pkg/printers/internalversion:go_default_library", "//pkg/util/i18n:go_default_library", "//pkg/util/strings:go_default_library", - "//pkg/util/term:go_default_library", "//vendor/github.com/go-openapi/spec:go_default_library", "//vendor/github.com/spf13/cobra:go_default_library", "//vendor/github.com/stretchr/testify/assert:go_default_library", diff --git a/pkg/kubectl/cmd/exec.go b/pkg/kubectl/cmd/exec.go index 84d76f1a332..3ca48d9a689 100644 --- a/pkg/kubectl/cmd/exec.go +++ b/pkg/kubectl/cmd/exec.go @@ -32,9 +32,9 @@ import ( coreclient "k8s.io/kubernetes/pkg/client/clientset_generated/internalclientset/typed/core/internalversion" "k8s.io/kubernetes/pkg/kubectl/cmd/templates" cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util" + "k8s.io/kubernetes/pkg/kubectl/util/term" "k8s.io/kubernetes/pkg/util/i18n" "k8s.io/kubernetes/pkg/util/interrupt" - "k8s.io/kubernetes/pkg/util/term" ) var ( diff --git a/pkg/kubectl/cmd/exec_test.go b/pkg/kubectl/cmd/exec_test.go index 8d72c724bc4..6c57bbd80c0 100644 --- a/pkg/kubectl/cmd/exec_test.go +++ b/pkg/kubectl/cmd/exec_test.go @@ -35,7 +35,7 @@ import ( "k8s.io/client-go/tools/remotecommand" "k8s.io/kubernetes/pkg/api" cmdtesting "k8s.io/kubernetes/pkg/kubectl/cmd/testing" - "k8s.io/kubernetes/pkg/util/term" + "k8s.io/kubernetes/pkg/kubectl/util/term" ) type fakeRemoteExecutor struct { diff --git a/pkg/kubectl/cmd/templates/BUILD b/pkg/kubectl/cmd/templates/BUILD index 4ee1ce4ab0f..7255c533561 100644 --- a/pkg/kubectl/cmd/templates/BUILD +++ b/pkg/kubectl/cmd/templates/BUILD @@ -19,7 +19,7 @@ go_library( "//build/visible_to:pkg_kubectl_cmd_templates_CONSUMERS", ], deps = [ - "//pkg/util/term:go_default_library", + "//pkg/kubectl/util/term:go_default_library", "//vendor/github.com/MakeNowJust/heredoc:go_default_library", "//vendor/github.com/russross/blackfriday:go_default_library", "//vendor/github.com/spf13/cobra:go_default_library", diff --git a/pkg/kubectl/cmd/templates/templater.go b/pkg/kubectl/cmd/templates/templater.go index 30c128ef3b2..27b76dc42b7 100644 --- a/pkg/kubectl/cmd/templates/templater.go +++ b/pkg/kubectl/cmd/templates/templater.go @@ -23,7 +23,7 @@ import ( "text/template" "unicode" - "k8s.io/kubernetes/pkg/util/term" + "k8s.io/kubernetes/pkg/kubectl/util/term" "github.com/spf13/cobra" flag "github.com/spf13/pflag" diff --git a/pkg/kubectl/cmd/util/editor/BUILD b/pkg/kubectl/cmd/util/editor/BUILD index 63544fd287d..328f1f3e55a 100644 --- a/pkg/kubectl/cmd/util/editor/BUILD +++ b/pkg/kubectl/cmd/util/editor/BUILD @@ -22,8 +22,8 @@ go_library( "//pkg/kubectl/cmd/util:go_default_library", "//pkg/kubectl/resource:go_default_library", "//pkg/kubectl/util/crlf:go_default_library", + "//pkg/kubectl/util/term:go_default_library", "//pkg/printers:go_default_library", - "//pkg/util/term:go_default_library", "//vendor/github.com/evanphx/json-patch:go_default_library", "//vendor/github.com/golang/glog:go_default_library", "//vendor/k8s.io/apimachinery/pkg/api/errors:go_default_library", diff --git a/pkg/kubectl/cmd/util/editor/editor.go b/pkg/kubectl/cmd/util/editor/editor.go index 9f53ee7c758..a53e8c0970a 100644 --- a/pkg/kubectl/cmd/util/editor/editor.go +++ b/pkg/kubectl/cmd/util/editor/editor.go @@ -29,7 +29,7 @@ import ( "github.com/golang/glog" - "k8s.io/kubernetes/pkg/util/term" + "k8s.io/kubernetes/pkg/kubectl/util/term" ) const ( diff --git a/pkg/kubectl/util/BUILD b/pkg/kubectl/util/BUILD index 7742aac0725..fb4b1fdac61 100644 --- a/pkg/kubectl/util/BUILD +++ b/pkg/kubectl/util/BUILD @@ -31,6 +31,7 @@ filegroup( srcs = [ ":package-srcs", "//pkg/kubectl/util/crlf:all-srcs", + "//pkg/kubectl/util/term:all-srcs", ], tags = ["automanaged"], visibility = ["//build/visible_to:pkg_kubectl_util_CONSUMERS"], diff --git a/pkg/util/term/BUILD b/pkg/kubectl/util/term/BUILD similarity index 100% rename from pkg/util/term/BUILD rename to pkg/kubectl/util/term/BUILD diff --git a/pkg/util/term/resize.go b/pkg/kubectl/util/term/resize.go similarity index 100% rename from pkg/util/term/resize.go rename to pkg/kubectl/util/term/resize.go diff --git a/pkg/util/term/resizeevents.go b/pkg/kubectl/util/term/resizeevents.go similarity index 100% rename from pkg/util/term/resizeevents.go rename to pkg/kubectl/util/term/resizeevents.go diff --git a/pkg/util/term/resizeevents_windows.go b/pkg/kubectl/util/term/resizeevents_windows.go similarity index 100% rename from pkg/util/term/resizeevents_windows.go rename to pkg/kubectl/util/term/resizeevents_windows.go diff --git a/pkg/util/term/setsize.go b/pkg/kubectl/util/term/setsize.go similarity index 100% rename from pkg/util/term/setsize.go rename to pkg/kubectl/util/term/setsize.go diff --git a/pkg/util/term/setsize_unsupported.go b/pkg/kubectl/util/term/setsize_unsupported.go similarity index 100% rename from pkg/util/term/setsize_unsupported.go rename to pkg/kubectl/util/term/setsize_unsupported.go diff --git a/pkg/util/term/term.go b/pkg/kubectl/util/term/term.go similarity index 100% rename from pkg/util/term/term.go rename to pkg/kubectl/util/term/term.go diff --git a/pkg/util/term/term_writer.go b/pkg/kubectl/util/term/term_writer.go similarity index 100% rename from pkg/util/term/term_writer.go rename to pkg/kubectl/util/term/term_writer.go diff --git a/pkg/util/term/term_writer_test.go b/pkg/kubectl/util/term/term_writer_test.go similarity index 100% rename from pkg/util/term/term_writer_test.go rename to pkg/kubectl/util/term/term_writer_test.go diff --git a/pkg/kubelet/dockershim/BUILD b/pkg/kubelet/dockershim/BUILD index 915b6b8485d..a2b81a5ecc7 100644 --- a/pkg/kubelet/dockershim/BUILD +++ b/pkg/kubelet/dockershim/BUILD @@ -53,9 +53,9 @@ go_library( "//pkg/security/apparmor:go_default_library", "//pkg/util/exec:go_default_library", "//pkg/util/hash:go_default_library", - "//pkg/util/term:go_default_library", "//vendor/github.com/blang/semver:go_default_library", "//vendor/github.com/docker/docker/pkg/jsonmessage:go_default_library", + "//vendor/github.com/docker/docker/pkg/term:go_default_library", "//vendor/github.com/docker/engine-api/types:go_default_library", "//vendor/github.com/docker/engine-api/types/container:go_default_library", "//vendor/github.com/docker/engine-api/types/filters:go_default_library", diff --git a/pkg/kubelet/dockershim/exec.go b/pkg/kubelet/dockershim/exec.go index 1d73a8a8d5c..2855af3b0e7 100644 --- a/pkg/kubelet/dockershim/exec.go +++ b/pkg/kubelet/dockershim/exec.go @@ -23,13 +23,13 @@ import ( "os/exec" "time" + "github.com/docker/docker/pkg/term" dockertypes "github.com/docker/engine-api/types" "github.com/golang/glog" "k8s.io/client-go/tools/remotecommand" kubecontainer "k8s.io/kubernetes/pkg/kubelet/container" utilexec "k8s.io/kubernetes/pkg/util/exec" - "k8s.io/kubernetes/pkg/util/term" "k8s.io/kubernetes/pkg/kubelet/dockershim/libdocker" ) @@ -89,7 +89,7 @@ func (*NsenterExecHandler) ExecInContainer(client libdocker.Interface, container defer stdout.Close() kubecontainer.HandleResizing(resize, func(size remotecommand.TerminalSize) { - term.SetSize(p.Fd(), size) + term.SetWinsize(p.Fd(), &term.Winsize{Height: size.Height, Width: size.Width}) }) if stdin != nil { diff --git a/pkg/kubelet/rkt/BUILD b/pkg/kubelet/rkt/BUILD index 35abb2b2b73..f80e2c6c830 100644 --- a/pkg/kubelet/rkt/BUILD +++ b/pkg/kubelet/rkt/BUILD @@ -39,13 +39,13 @@ go_library( "//pkg/util/parsers:go_default_library", "//pkg/util/selinux:go_default_library", "//pkg/util/strings:go_default_library", - "//pkg/util/term:go_default_library", "//pkg/util/version:go_default_library", "//vendor/github.com/appc/spec/schema:go_default_library", "//vendor/github.com/appc/spec/schema/types:go_default_library", "//vendor/github.com/coreos/go-systemd/dbus:go_default_library", "//vendor/github.com/coreos/go-systemd/unit:go_default_library", "//vendor/github.com/coreos/rkt/api/v1alpha:go_default_library", + "//vendor/github.com/docker/docker/pkg/term:go_default_library", "//vendor/github.com/docker/engine-api/types:go_default_library", "//vendor/github.com/golang/glog:go_default_library", "//vendor/golang.org/x/net/context:go_default_library", diff --git a/pkg/kubelet/rkt/rkt.go b/pkg/kubelet/rkt/rkt.go index 8a1ff5e9e79..e4481e37d9a 100644 --- a/pkg/kubelet/rkt/rkt.go +++ b/pkg/kubelet/rkt/rkt.go @@ -38,6 +38,7 @@ import ( appctypes "github.com/appc/spec/schema/types" "github.com/coreos/go-systemd/unit" rktapi "github.com/coreos/rkt/api/v1alpha" + "github.com/docker/docker/pkg/term" "github.com/golang/glog" "golang.org/x/net/context" "google.golang.org/grpc" @@ -65,7 +66,6 @@ import ( utilexec "k8s.io/kubernetes/pkg/util/exec" "k8s.io/kubernetes/pkg/util/selinux" utilstrings "k8s.io/kubernetes/pkg/util/strings" - "k8s.io/kubernetes/pkg/util/term" ) const ( @@ -2175,7 +2175,7 @@ func (r *Runtime) ExecInContainer(containerID kubecontainer.ContainerID, cmd []s defer stdout.Close() kubecontainer.HandleResizing(resize, func(size remotecommand.TerminalSize) { - term.SetSize(p.Fd(), size) + term.SetWinsize(p.Fd(), &term.Winsize{Height: size.Height, Width: size.Width}) }) if stdin != nil { diff --git a/pkg/util/BUILD b/pkg/util/BUILD index 4d03d9cde70..c7048bed481 100644 --- a/pkg/util/BUILD +++ b/pkg/util/BUILD @@ -90,7 +90,6 @@ filegroup( "//pkg/util/system:all-srcs", "//pkg/util/tail:all-srcs", "//pkg/util/taints:all-srcs", - "//pkg/util/term:all-srcs", "//pkg/util/threading:all-srcs", "//pkg/util/tolerations:all-srcs", "//pkg/util/uuid:all-srcs",