github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-05 02:09:56 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #34093 from wojtek-t/fix_index_listing

Browse Source 
Automatic merge from submit-queue

Fix call to Index call in listers

This will actually eliminated all logs like this:
```
can not retrieve list of objects using index : object has no meta: object does not implement the Object interfaces
```

And it should also speed up different things (as so far we we basically not using indexes at all.

@kubernetes/sig-api-machinery
This commit is contained in:
Kubernetes Submit Queue 2016-10-05 07:45:58 -07:00 committed by GitHub
commit 740458255b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/client/cache/listers.go vendored
View File

@ -62,7 +62,7 @@ func ListAllByNamespace(indexer Indexer, namespace string, selector labels.Selec
return nil return nil
} }
items, err := indexer.Index(NamespaceIndex, api.ObjectMeta{Namespace: namespace}) items, err := indexer.Index(NamespaceIndex, &api.ObjectMeta{Namespace: namespace})
if err != nil { if err != nil {
// Ignore error; do slow search without index. // Ignore error; do slow search without index.
glog.Warningf("can not retrieve list of objects using index : %v", err) glog.Warningf("can not retrieve list of objects using index : %v", err)