diff --git a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/conversion/webhook_converter_test.go b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/conversion/webhook_converter_test.go index a1ca6a2a60a..5c6766c09c1 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/conversion/webhook_converter_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/conversion/webhook_converter_test.go @@ -23,13 +23,13 @@ import ( "github.com/google/go-cmp/cmp" - v1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" - "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" "k8s.io/apimachinery/pkg/runtime" - "k8s.io/apimachinery/pkg/util/diff" "k8s.io/apimachinery/pkg/util/validation" + + v1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" + "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1" ) func TestRestoreObjectMeta(t *testing.T) { @@ -200,7 +200,7 @@ func TestRestoreObjectMeta(t *testing.T) { } if !reflect.DeepEqual(tt.converted, tt.expected) { - t.Errorf("unexpected result: %s", diff.ObjectDiff(tt.expected, tt.converted)) + t.Errorf("unexpected result: %s", cmp.Diff(tt.expected, tt.converted)) } }) } diff --git a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/convert_test.go b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/convert_test.go index 2910a28c2ad..66b89b01142 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/convert_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/convert_test.go @@ -22,11 +22,11 @@ import ( "testing" "time" + "github.com/google/go-cmp/cmp" fuzz "github.com/google/gofuzz" "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions" apiextensionsv1beta1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1beta1" - "k8s.io/apimachinery/pkg/util/diff" "k8s.io/apimachinery/pkg/util/json" ) @@ -100,7 +100,7 @@ func TestStructuralRoundtripOrError(t *testing.T) { } if !reflect.DeepEqual(origSchema, internalSchema) { - t.Fatalf("original and result differ: %v", diff.ObjectDiff(origSchema, internalSchema)) + t.Fatalf("original and result differ: %v", cmp.Diff(origSchema, internalSchema)) } } } diff --git a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/objectmeta/algorithm_test.go b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/objectmeta/algorithm_test.go index 01b516c42e7..cd36ef85a87 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/objectmeta/algorithm_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/objectmeta/algorithm_test.go @@ -22,9 +22,11 @@ import ( "strings" "testing" - structuralschema "k8s.io/apiextensions-apiserver/pkg/apiserver/schema" - "k8s.io/apimachinery/pkg/util/diff" + "github.com/google/go-cmp/cmp" + "k8s.io/apimachinery/pkg/util/json" + + structuralschema "k8s.io/apiextensions-apiserver/pkg/apiserver/schema" ) func TestCoerce(t *testing.T) { @@ -523,7 +525,7 @@ func TestCoerce(t *testing.T) { if err != nil { t.Fatalf("unexpected result mashalling error: %v", err) } - t.Errorf("expected: %s\ngot: %s\ndiff: %s", tt.expected, buf.String(), diff.ObjectDiff(expected, in)) + t.Errorf("expected: %s\ngot: %s\ndiff: %s", tt.expected, buf.String(), cmp.Diff(expected, in)) } if !reflect.DeepEqual(unknownFields, tt.expectedUnknownFields) { t.Errorf("expected unknown fields:\n\t%v\ngot:\n\t%v\n", strings.Join(tt.expectedUnknownFields, "\n\t"), strings.Join(unknownFields, "\n\t")) diff --git a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/pruning/algorithm_test.go b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/pruning/algorithm_test.go index 176b3a2c92d..6d06f9434de 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/pruning/algorithm_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/pkg/apiserver/schema/pruning/algorithm_test.go @@ -22,10 +22,12 @@ import ( "strings" "testing" - structuralschema "k8s.io/apiextensions-apiserver/pkg/apiserver/schema" + "github.com/google/go-cmp/cmp" + "k8s.io/apimachinery/pkg/runtime" - "k8s.io/apimachinery/pkg/util/diff" "k8s.io/apimachinery/pkg/util/json" + + structuralschema "k8s.io/apiextensions-apiserver/pkg/apiserver/schema" ) func TestPrune(t *testing.T) { @@ -586,7 +588,7 @@ func TestPrune(t *testing.T) { if err != nil { t.Fatalf("unexpected result mashalling error: %v", err) } - t.Errorf("expected object: %s\ngot: %s\ndiff: %s", tt.expectedObject, buf.String(), diff.ObjectDiff(expectedObject, in)) + t.Errorf("expected object: %s\ngot: %s\ndiff: %s", tt.expectedObject, buf.String(), cmp.Diff(expectedObject, in)) } if !reflect.DeepEqual(pruned, tt.expectedPruned) { t.Errorf("expected pruned:\n\t%v\ngot:\n\t%v\n", strings.Join(tt.expectedPruned, "\n\t"), strings.Join(pruned, "\n\t")) @@ -602,7 +604,7 @@ func TestPrune(t *testing.T) { if err != nil { t.Fatalf("unexpected result mashalling error: %v", err) } - t.Errorf("expected object: %s\ngot: %s\ndiff: %s", tt.expectedObject, buf.String(), diff.ObjectDiff(expectedObject, in)) + t.Errorf("expected object: %s\ngot: %s\ndiff: %s", tt.expectedObject, buf.String(), cmp.Diff(expectedObject, in)) } if len(emptyPruned) > 0 { t.Errorf("unexpectedly returned pruned fields: %v", emptyPruned) diff --git a/staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/etcd_test.go b/staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/etcd_test.go index 87d50e623ff..151f5e6c545 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/etcd_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresource/etcd_test.go @@ -24,6 +24,8 @@ import ( "testing" "time" + "github.com/google/go-cmp/cmp" + autoscalingv1 "k8s.io/api/autoscaling/v1" apiequality "k8s.io/apimachinery/pkg/api/equality" "k8s.io/apimachinery/pkg/api/errors" @@ -32,7 +34,6 @@ import ( "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" - "k8s.io/apimachinery/pkg/util/diff" "k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager" genericapirequest "k8s.io/apiserver/pkg/endpoints/request" "k8s.io/apiserver/pkg/registry/generic" @@ -408,7 +409,7 @@ func TestScaleGet(t *testing.T) { got := obj.(*autoscalingv1.Scale) if !apiequality.Semantic.DeepEqual(got, want) { - t.Errorf("unexpected scale: %s", diff.ObjectDiff(got, want)) + t.Errorf("unexpected scale: %s", cmp.Diff(got, want)) } } diff --git a/staging/src/k8s.io/apiextensions-apiserver/test/integration/objectmeta_test.go b/staging/src/k8s.io/apiextensions-apiserver/test/integration/objectmeta_test.go index b588c8c2df3..fe6f0607cb2 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/test/integration/objectmeta_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/test/integration/objectmeta_test.go @@ -24,24 +24,25 @@ import ( "testing" "time" + "github.com/google/go-cmp/cmp" "go.etcd.io/etcd/client/pkg/v3/transport" clientv3 "go.etcd.io/etcd/client/v3" "google.golang.org/grpc" "sigs.k8s.io/yaml" - apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" - "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset" - serveroptions "k8s.io/apiextensions-apiserver/pkg/cmd/server/options" - "k8s.io/apiextensions-apiserver/test/integration/fixtures" "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" "k8s.io/apimachinery/pkg/runtime/schema" - "k8s.io/apimachinery/pkg/util/diff" "k8s.io/apimachinery/pkg/util/json" genericapirequest "k8s.io/apiserver/pkg/endpoints/request" "k8s.io/client-go/dynamic" "k8s.io/utils/pointer" + + apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" + "k8s.io/apiextensions-apiserver/pkg/client/clientset/clientset" + serveroptions "k8s.io/apiextensions-apiserver/pkg/cmd/server/options" + "k8s.io/apiextensions-apiserver/test/integration/fixtures" ) func TestPostInvalidObjectMeta(t *testing.T) { @@ -465,7 +466,7 @@ func TestEmbeddedResources(t *testing.T) { t.Fatal(err) } if !reflect.DeepEqual(expected, foo.Object) { - t.Errorf("unexpected diff: %s", diff.ObjectDiff(expected, foo.Object)) + t.Errorf("unexpected diff: %s", cmp.Diff(expected, foo.Object)) } t.Logf("Trying to create wrongly typed CR") diff --git a/staging/src/k8s.io/apiextensions-apiserver/test/integration/pruning_test.go b/staging/src/k8s.io/apiextensions-apiserver/test/integration/pruning_test.go index eb8f38925a9..4db9d1ec652 100644 --- a/staging/src/k8s.io/apiextensions-apiserver/test/integration/pruning_test.go +++ b/staging/src/k8s.io/apiextensions-apiserver/test/integration/pruning_test.go @@ -24,6 +24,8 @@ import ( "testing" "time" + "github.com/google/go-cmp/cmp" + apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" "go.etcd.io/etcd/client/pkg/v3/transport" @@ -37,7 +39,6 @@ import ( "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" types "k8s.io/apimachinery/pkg/types" - "k8s.io/apimachinery/pkg/util/diff" "k8s.io/apimachinery/pkg/util/json" genericapirequest "k8s.io/apiserver/pkg/endpoints/request" "k8s.io/client-go/dynamic" @@ -598,6 +599,6 @@ embeddedNested: t.Fatal(err) } if !reflect.DeepEqual(expected, x) { - t.Errorf("unexpected diff: %s", diff.ObjectDiff(expected, x)) + t.Errorf("unexpected diff: %s", cmp.Diff(expected, x)) } }