Merge pull request #77670 from bjhaid/cleanup_pkg_api

Clean up pkg/api.
This commit is contained in:
Kubernetes Prow Robot
2019-05-10 21:31:02 -07:00
committed by GitHub
5 changed files with 7 additions and 8 deletions

View File

@@ -604,8 +604,7 @@ func TestUpdatePodCondition(t *testing.T) {
}
for _, test := range tests {
var resultStatus bool
resultStatus = UpdatePodCondition(test.status, &test.conditions)
resultStatus := UpdatePodCondition(test.status, &test.conditions)
assert.Equal(t, test.expected, resultStatus, test.desc)
}

View File

@@ -53,13 +53,13 @@ func TestGetLoadBalancerSourceRanges(t *testing.T) {
annotations[v1.AnnotationLoadBalancerSourceRangesKey] = v
svc := v1.Service{}
svc.Annotations = annotations
cidrs, err := GetLoadBalancerSourceRanges(&svc)
_, err := GetLoadBalancerSourceRanges(&svc)
if err != nil {
t.Errorf("Unexpected error parsing: %q", v)
}
svc = v1.Service{}
svc.Spec.LoadBalancerSourceRanges = strings.Split(v, ",")
cidrs, err = GetLoadBalancerSourceRanges(&svc)
cidrs, err := GetLoadBalancerSourceRanges(&svc)
if err != nil {
t.Errorf("Unexpected error parsing: %q", v)
}