From 74ce6e9f1b62af0ca9c27fd2efec797aa332f77a Mon Sep 17 00:00:00 2001 From: xovoxy Date: Wed, 14 Aug 2024 11:15:31 +0800 Subject: [PATCH] cleanup: Use map[string]struct{} instead of map[string]bool for memory optimization Signed-off-by: xovoxy --- staging/src/k8s.io/component-base/cli/flag/flags.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/component-base/cli/flag/flags.go b/staging/src/k8s.io/component-base/cli/flag/flags.go index 2388340d5ca..8d4a59ce968 100644 --- a/staging/src/k8s.io/component-base/cli/flag/flags.go +++ b/staging/src/k8s.io/component-base/cli/flag/flags.go @@ -24,7 +24,7 @@ import ( "k8s.io/klog/v2" ) -var underscoreWarnings = make(map[string]bool) +var underscoreWarnings = make(map[string]struct{}) // WordSepNormalizeFunc changes all flags that contain "_" separators func WordSepNormalizeFunc(f *pflag.FlagSet, name string) pflag.NormalizedName { @@ -40,7 +40,7 @@ func WarnWordSepNormalizeFunc(f *pflag.FlagSet, name string) pflag.NormalizedNam nname := strings.Replace(name, "_", "-", -1) if _, alreadyWarned := underscoreWarnings[name]; !alreadyWarned { klog.Warningf("using an underscore in a flag name is not supported. %s has been converted to %s.", name, nname) - underscoreWarnings[name] = true + underscoreWarnings[name] = struct{}{} } return pflag.NormalizedName(nname)