From 7582a768b7e58bb9135689f01891f12efd87bb75 Mon Sep 17 00:00:00 2001 From: carlory Date: Mon, 13 May 2024 12:08:57 +0800 Subject: [PATCH] kubeadm: remove outdate todo --- cmd/kubeadm/app/cmd/upgrade/diff_test.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cmd/kubeadm/app/cmd/upgrade/diff_test.go b/cmd/kubeadm/app/cmd/upgrade/diff_test.go index 8a127de8db0..8d7d858a69b 100644 --- a/cmd/kubeadm/app/cmd/upgrade/diff_test.go +++ b/cmd/kubeadm/app/cmd/upgrade/diff_test.go @@ -86,7 +86,6 @@ diff: out: io.Discard, } - // TODO: Add test cases for empty cfgPath, it should automatically fetch cfg from cluster testCases := []struct { name string args []string @@ -95,6 +94,13 @@ diff: cfgPath string expectedError bool }{ + { + name: "valid: run diff with empty config path on valid manifest path", + cfgPath: "", + setManifestPath: true, + manifestPath: testUpgradeDiffManifest, + expectedError: false, + }, { name: "valid: run diff on valid manifest path", cfgPath: testUpgradeDiffConfig,