Merge pull request #101313 from BinacsLee/binacs-scheduler-fwk-types-cleanup

code cleanup: scheduler / framework use `max` function instead of if-cond…
This commit is contained in:
Kubernetes Prow Robot 2021-04-21 17:04:13 -07:00 committed by GitHub
commit 75b846dee4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -554,25 +554,16 @@ func (r *Resource) SetMaxResource(rl v1.ResourceList) {
for rName, rQuantity := range rl {
switch rName {
case v1.ResourceMemory:
if mem := rQuantity.Value(); mem > r.Memory {
r.Memory = mem
}
r.Memory = max(r.Memory, rQuantity.Value())
case v1.ResourceCPU:
if cpu := rQuantity.MilliValue(); cpu > r.MilliCPU {
r.MilliCPU = cpu
}
r.MilliCPU = max(r.MilliCPU, rQuantity.MilliValue())
case v1.ResourceEphemeralStorage:
if utilfeature.DefaultFeatureGate.Enabled(features.LocalStorageCapacityIsolation) {
if ephemeralStorage := rQuantity.Value(); ephemeralStorage > r.EphemeralStorage {
r.EphemeralStorage = ephemeralStorage
}
r.EphemeralStorage = max(r.EphemeralStorage, rQuantity.Value())
}
default:
if schedutil.IsScalarResourceName(rName) {
value := rQuantity.Value()
if value > r.ScalarResources[rName] {
r.SetScalar(rName, value)
}
r.SetScalar(rName, max(r.ScalarResources[rName], rQuantity.Value()))
}
}
}