From 13cecd6e4a07c1f2269f8aa45e90c8266f25fc72 Mon Sep 17 00:00:00 2001 From: Charlie Drage Date: Thu, 14 Jul 2016 11:48:45 -0400 Subject: [PATCH] Warn when missing cloud-provider on kube controller This commit warns the user / gives better information that when using --cloud-provider="" on kube-controller, that services such as LoadBalancer will not work. However, despite the error, kube-controller will still run as normal. Fixes https://github.com/kubernetes/kubernetes/issues/12716 Fixes https://github.com/kubernetes/kubernetes/issues/11172 Fixes https://github.com/kubernetes/kubernetes/issues/27085 --- pkg/controller/service/servicecontroller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/service/servicecontroller.go b/pkg/controller/service/servicecontroller.go index 884d5384047..3fb7361beeb 100644 --- a/pkg/controller/service/servicecontroller.go +++ b/pkg/controller/service/servicecontroller.go @@ -160,7 +160,7 @@ func (s *ServiceController) Run(serviceSyncPeriod, nodeSyncPeriod time.Duration) func (s *ServiceController) init() error { if s.cloud == nil { - return fmt.Errorf("ServiceController should not be run without a cloudprovider.") + return fmt.Errorf("WARNING: no cloud provider provided, services of type LoadBalancer will fail.") } balancer, ok := s.cloud.LoadBalancer()