From 7640280284b9ad490d798dcdcf3beea92d18a3a7 Mon Sep 17 00:00:00 2001 From: Deyuan Deng Date: Fri, 3 Oct 2014 21:38:29 -0400 Subject: [PATCH] Ignore empty pod port spec. --- pkg/kubecfg/kubecfg.go | 3 +++ pkg/kubecfg/kubecfg_test.go | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/pkg/kubecfg/kubecfg.go b/pkg/kubecfg/kubecfg.go index 03c84221d4e..d4d9c1ffb89 100644 --- a/pkg/kubecfg/kubecfg.go +++ b/pkg/kubecfg/kubecfg.go @@ -159,6 +159,9 @@ func ResizeController(ctx api.Context, name string, replicas int, client client. } func portsFromString(spec string) []api.Port { + if spec == "" { + return []api.Port{} + } parts := strings.Split(spec, ",") var result []api.Port for _, part := range parts { diff --git a/pkg/kubecfg/kubecfg_test.go b/pkg/kubecfg/kubecfg_test.go index 84b8d7c0abc..399a85f330b 100644 --- a/pkg/kubecfg/kubecfg_test.go +++ b/pkg/kubecfg/kubecfg_test.go @@ -285,6 +285,10 @@ func TestMakePorts(t *testing.T) { {HostPort: 443, ContainerPort: 444}, }, }, + { + "", + []api.Port{}, + }, } for _, tt := range testCases { ports := portsFromString(tt.spec)