From 765057765c5b24d928ed8bfb34ffbd0fb2d350da Mon Sep 17 00:00:00 2001 From: Vy Ta Date: Tue, 8 Jan 2019 10:11:35 -0800 Subject: [PATCH] golint failure updates, and added skip check for non-windows --- hack/.golint_failures | 1 + test/e2e/BUILD | 1 + test/e2e/windows/density.go | 5 +++++ 3 files changed, 7 insertions(+) diff --git a/hack/.golint_failures b/hack/.golint_failures index bee5a5a403d..2abec9c894b 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -749,6 +749,7 @@ test/e2e/ui test/e2e/upgrades test/e2e/upgrades/apps test/e2e/upgrades/storage +test/e2e/windows test/e2e_kubeadm test/e2e_node test/e2e_node/builder diff --git a/test/e2e/BUILD b/test/e2e/BUILD index 1625d51ea0d..550d1a23bac 100644 --- a/test/e2e/BUILD +++ b/test/e2e/BUILD @@ -121,6 +121,7 @@ filegroup( "//test/e2e/testing-manifests:all-srcs", "//test/e2e/ui:all-srcs", "//test/e2e/upgrades:all-srcs", + "//test/e2e/windows:all-srcs" ], tags = ["automanaged"], ) diff --git a/test/e2e/windows/density.go b/test/e2e/windows/density.go index bd1f6b55d91..03370d74b4f 100644 --- a/test/e2e/windows/density.go +++ b/test/e2e/windows/density.go @@ -40,6 +40,11 @@ var _ = SIGDescribe("[Feature:Windows] Density [Serial] [Slow]", func() { f := framework.NewDefaultFramework("density-test-windows") + BeforeEach(func() { + // NOTE(vyta): these tests are Windows specific + framework.SkipUnlessNodeOSDistroIs("windows") + }) + Context("create a batch of pods", func() { // TODO(coufon): the values are generous, set more precise limits with benchmark data // and add more tests