From f52628db600e9ceac4727595ed57c5b96cf8fb92 Mon Sep 17 00:00:00 2001 From: Rohit Agarwal Date: Tue, 19 Dec 2017 00:43:39 -0800 Subject: [PATCH] Deprecate the alpha Accelerators feature gate. Encourage people to use DevicePlugins instead. --- pkg/features/kube_features.go | 2 ++ pkg/kubelet/kubelet.go | 1 + 2 files changed, 3 insertions(+) diff --git a/pkg/features/kube_features.go b/pkg/features/kube_features.go index d500a7fd3b5..f12e0c342c4 100644 --- a/pkg/features/kube_features.go +++ b/pkg/features/kube_features.go @@ -64,6 +64,8 @@ const ( // owner: @vishh // alpha: v1.6 // + // This is deprecated and will be removed in v1.11. Use DevicePlugins instead. + // // Enables support for GPUs as a schedulable resource. // Only Nvidia GPUs are supported as of v1.6. // Works only with Docker Container Runtime. diff --git a/pkg/kubelet/kubelet.go b/pkg/kubelet/kubelet.go index 632ef952f3d..eb335301f31 100644 --- a/pkg/kubelet/kubelet.go +++ b/pkg/kubelet/kubelet.go @@ -875,6 +875,7 @@ func NewMainKubelet(kubeCfg *kubeletconfiginternal.KubeletConfiguration, klet.softAdmitHandlers.AddPodAdmitHandler(lifecycle.NewNoNewPrivsAdmitHandler(klet.containerRuntime)) if utilfeature.DefaultFeatureGate.Enabled(features.Accelerators) { if containerRuntime == kubetypes.DockerContainerRuntime { + glog.Warningln("Accelerators feature is deprecated and will be removed in v1.11. Please use device plugins instead. They can be enabled using the DevicePlugins feature gate.") if klet.gpuManager, err = nvidia.NewNvidiaGPUManager(klet, kubeDeps.DockerClientConfig); err != nil { return nil, err }