From 772dbbc7d78c909fa68fc5218886a2b517c94ca2 Mon Sep 17 00:00:00 2001 From: Philipp Stehle Date: Tue, 3 Dec 2019 14:33:31 +0100 Subject: [PATCH] Fix describe of statefulset prints pointer not value --- staging/src/k8s.io/kubectl/pkg/describe/versioned/describe.go | 2 +- .../k8s.io/kubectl/pkg/describe/versioned/describe_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/staging/src/k8s.io/kubectl/pkg/describe/versioned/describe.go b/staging/src/k8s.io/kubectl/pkg/describe/versioned/describe.go index d6edbe2e0d5..c73280300bd 100644 --- a/staging/src/k8s.io/kubectl/pkg/describe/versioned/describe.go +++ b/staging/src/k8s.io/kubectl/pkg/describe/versioned/describe.go @@ -3187,7 +3187,7 @@ func describeStatefulSet(ps *appsv1.StatefulSet, selector labels.Selector, event if ps.Spec.UpdateStrategy.RollingUpdate != nil { ru := ps.Spec.UpdateStrategy.RollingUpdate if ru.Partition != nil { - w.Write(LEVEL_1, "Partition:\t%d\n", ru.Partition) + w.Write(LEVEL_1, "Partition:\t%d\n", *ru.Partition) } } diff --git a/staging/src/k8s.io/kubectl/pkg/describe/versioned/describe_test.go b/staging/src/k8s.io/kubectl/pkg/describe/versioned/describe_test.go index bde4fc051c3..7c5573bf4ca 100644 --- a/staging/src/k8s.io/kubectl/pkg/describe/versioned/describe_test.go +++ b/staging/src/k8s.io/kubectl/pkg/describe/versioned/describe_test.go @@ -3544,7 +3544,7 @@ func TestDescribeNode(t *testing.T) { } func TestDescribeStatefulSet(t *testing.T) { - var partition int32 = 2 + var partition int32 = 2672 var replicas int32 = 1 fake := fake.NewSimpleClientset(&appsv1.StatefulSet{ ObjectMeta: metav1.ObjectMeta{ @@ -3575,7 +3575,7 @@ func TestDescribeStatefulSet(t *testing.T) { t.Errorf("unexpected error: %v", err) } expectedOutputs := []string{ - "bar", "foo", "Containers:", "mytest-image:latest", "Update Strategy", "RollingUpdate", "Partition", + "bar", "foo", "Containers:", "mytest-image:latest", "Update Strategy", "RollingUpdate", "Partition", "2672", } for _, o := range expectedOutputs { if !strings.Contains(out, o) {