diff --git a/pkg/controller/podautoscaler/metrics/rest_metrics_client.go b/pkg/controller/podautoscaler/metrics/rest_metrics_client.go index 07dd290a563..e8894bfcc95 100644 --- a/pkg/controller/podautoscaler/metrics/rest_metrics_client.go +++ b/pkg/controller/podautoscaler/metrics/rest_metrics_client.go @@ -58,11 +58,11 @@ type resourceMetricsClient struct { func (c *resourceMetricsClient) GetResourceMetric(resource v1.ResourceName, namespace string, selector labels.Selector) (PodMetricsInfo, time.Time, error) { metrics, err := c.client.PodMetricses(namespace).List(metav1.ListOptions{LabelSelector: selector.String()}) if err != nil { - return nil, time.Time{}, fmt.Errorf("unable to fetch metrics from API: %v", err) + return nil, time.Time{}, fmt.Errorf("unable to fetch metrics from resource metrics API: %v", err) } if len(metrics.Items) == 0 { - return nil, time.Time{}, fmt.Errorf("no metrics returned from heapster") + return nil, time.Time{}, fmt.Errorf("no metrics returned from resource metrics API") } res := make(PodMetricsInfo, len(metrics.Items)) @@ -101,7 +101,7 @@ type customMetricsClient struct { func (c *customMetricsClient) GetRawMetric(metricName string, namespace string, selector labels.Selector) (PodMetricsInfo, time.Time, error) { metrics, err := c.client.NamespacedMetrics(namespace).GetForObjects(schema.GroupKind{Kind: "Pod"}, selector, metricName) if err != nil { - return nil, time.Time{}, fmt.Errorf("unable to fetch metrics from API: %v", err) + return nil, time.Time{}, fmt.Errorf("unable to fetch metrics from custom metrics API: %v", err) } if len(metrics.Items) == 0 { @@ -134,7 +134,7 @@ func (c *customMetricsClient) GetObjectMetric(metricName string, namespace strin } if err != nil { - return 0, time.Time{}, fmt.Errorf("unable to fetch metrics from API: %v", err) + return 0, time.Time{}, fmt.Errorf("unable to fetch metrics from custom metrics API: %v", err) } return metricValue.Value.MilliValue(), metricValue.Timestamp.Time, nil diff --git a/pkg/controller/podautoscaler/metrics/rest_metrics_client_test.go b/pkg/controller/podautoscaler/metrics/rest_metrics_client_test.go index d9a178a7554..289b93f04d7 100644 --- a/pkg/controller/podautoscaler/metrics/rest_metrics_client_test.go +++ b/pkg/controller/podautoscaler/metrics/rest_metrics_client_test.go @@ -252,7 +252,7 @@ func TestRESTClientQpsSumEqualZero(t *testing.T) { func TestRESTClientCPUEmptyMetrics(t *testing.T) { tc := restClientTestCase{ resourceName: v1.ResourceCPU, - desiredError: fmt.Errorf("no metrics returned from heapster"), + desiredError: fmt.Errorf("no metrics returned from resource metrics API"), reportedMetricPoints: []metricPoint{}, reportedPodMetrics: [][]int64{}, } diff --git a/pkg/controller/podautoscaler/replica_calculator_test.go b/pkg/controller/podautoscaler/replica_calculator_test.go index b12b62519b9..a5c3bf03872 100644 --- a/pkg/controller/podautoscaler/replica_calculator_test.go +++ b/pkg/controller/podautoscaler/replica_calculator_test.go @@ -579,7 +579,7 @@ func TestReplicaCalcMissingMetrics(t *testing.T) { func TestReplicaCalcEmptyMetrics(t *testing.T) { tc := replicaCalcTestCase{ currentReplicas: 4, - expectedError: fmt.Errorf("unable to get metrics for resource cpu: no metrics returned from heapster"), + expectedError: fmt.Errorf("unable to get metrics for resource cpu: no metrics returned from resource metrics API"), resource: &resourceInfo{ name: v1.ResourceCPU, requests: []resource.Quantity{resource.MustParse("1.0"), resource.MustParse("1.0"), resource.MustParse("1.0")},