From 77efbc411a05df3961247bb26616afc4ac5fa0f7 Mon Sep 17 00:00:00 2001 From: Tom Kerkhove Date: Wed, 4 May 2022 02:16:59 +0200 Subject: [PATCH] feat: Provide previous replica count for deployment/replica set scale up/down event (#101142) * feat: Provide previous replica count for deployment/replica set scale up/down event Signed-off-by: GitHub * change format of event Co-authored-by: Maciej Szulik Co-authored-by: Maciej Szulik --- pkg/controller/deployment/sync.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/controller/deployment/sync.go b/pkg/controller/deployment/sync.go index b5c67a9e1bc..acc90d2afc7 100644 --- a/pkg/controller/deployment/sync.go +++ b/pkg/controller/deployment/sync.go @@ -417,13 +417,14 @@ func (dc *DeploymentController) scaleReplicaSet(ctx context.Context, rs *apps.Re scaled := false var err error if sizeNeedsUpdate || annotationsNeedUpdate { + oldScale := *(rs.Spec.Replicas) rsCopy := rs.DeepCopy() *(rsCopy.Spec.Replicas) = newScale deploymentutil.SetReplicasAnnotations(rsCopy, *(deployment.Spec.Replicas), *(deployment.Spec.Replicas)+deploymentutil.MaxSurge(*deployment)) rs, err = dc.client.AppsV1().ReplicaSets(rsCopy.Namespace).Update(ctx, rsCopy, metav1.UpdateOptions{}) if err == nil && sizeNeedsUpdate { scaled = true - dc.eventRecorder.Eventf(deployment, v1.EventTypeNormal, "ScalingReplicaSet", "Scaled %s replica set %s to %d", scalingOperation, rs.Name, newScale) + dc.eventRecorder.Eventf(deployment, v1.EventTypeNormal, "ScalingReplicaSet", "Scaled %s replica set %s to %d from %d", scalingOperation, rs.Name, newScale, oldScale) } } return scaled, rs, err