From c4898d6f56020ec81a64d390588df079b8af7618 Mon Sep 17 00:00:00 2001 From: aaa <1693291525@qq.com> Date: Fri, 19 Apr 2019 20:03:29 -0400 Subject: [PATCH] fix shellcheck failures list-resources.sh update pull request update pull request update pull request --- cluster/gce/list-resources.sh | 8 ++++---- hack/.shellcheck_failures | 1 - 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/cluster/gce/list-resources.sh b/cluster/gce/list-resources.sh index 3e33075db8d..0caa6f41651 100755 --- a/cluster/gce/list-resources.sh +++ b/cluster/gce/list-resources.sh @@ -49,20 +49,20 @@ function gcloud-list() { local attempt=1 local result="" while true; do - if result=$(gcloud ${group} ${resource} list --project=${PROJECT} ${filter:+--filter="$filter"} ${@:4}); then - if [[ ! -z "${GREP_REGEX}" ]]; then + if result=$(gcloud "${group}" "${resource}" list --project="${PROJECT}" "${filter:+--filter="$filter"}" "${@:4}"); then + if [[ -n "${GREP_REGEX:-}" ]]; then result=$(echo "${result}" | grep "${GREP_REGEX}" || true) fi echo "${result}" return fi echo -e "Attempt ${attempt} failed to list ${resource}. Retrying." >&2 - attempt=$(($attempt+1)) + attempt=$((attempt + 1)) if [[ ${attempt} -gt 5 ]]; then echo -e "List ${resource} failed!" >&2 exit 2 fi - sleep $((5*${attempt})) + sleep $((5 * attempt)) done } diff --git a/hack/.shellcheck_failures b/hack/.shellcheck_failures index b068fc56f4d..76f76167d65 100644 --- a/hack/.shellcheck_failures +++ b/hack/.shellcheck_failures @@ -11,7 +11,6 @@ ./cluster/gce/gci/flexvolume_node_setup.sh ./cluster/gce/gci/health-monitor.sh ./cluster/gce/gci/master-helper.sh -./cluster/gce/list-resources.sh ./cluster/gce/upgrade-aliases.sh ./cluster/gce/upgrade.sh ./cluster/gce/util.sh