From 770b749436d465a44609e7be5afb6fce76a08f65 Mon Sep 17 00:00:00 2001 From: Michael Aspinwall Date: Mon, 18 Aug 2025 17:50:31 +0000 Subject: [PATCH] feat: Require SVM to use RealFIFO --- cmd/kube-controller-manager/app/storageversionmigrator.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cmd/kube-controller-manager/app/storageversionmigrator.go b/cmd/kube-controller-manager/app/storageversionmigrator.go index 99cf02e0953..4ff1b57cdbe 100644 --- a/cmd/kube-controller-manager/app/storageversionmigrator.go +++ b/cmd/kube-controller-manager/app/storageversionmigrator.go @@ -54,6 +54,11 @@ func startSVMController( return nil, true, fmt.Errorf("storage version migrator requires garbage collector") } + if !clientgofeaturegate.FeatureGates().Enabled(clientgofeaturegate.InOrderInformers) { + err := fmt.Errorf("storage version migrator requires the InOrderInformers feature gate to be enabled") + return nil, true, err + } + // svm controller can make a lot of requests during migration, keep it fast config := controllerContext.ClientBuilder.ConfigOrDie(controllerName) config.QPS *= 20