From 4bf980967add82c276ea77f2bede1549a8e4ea75 Mon Sep 17 00:00:00 2001 From: juanvallejo Date: Tue, 6 Sep 2016 14:28:49 -0400 Subject: [PATCH] remove call to compinit in zsh completion output Fixes: https://github.com/kubernetes/kubernetes/issues/32029 Fixes: https://github.com/kubernetes/kubernetes/issues/27538#issuecomment-238574035 The zsh completion output makes a call to "compinit" which causes the zsh completion system to re-initialize every time ` completion zsh` is sourced, overwriting any settings already applied to other commands. This in-turn caused other commands' completions to break (such as git, gcloud, vim) causing an error "function definition file not found" to be returned any time a tab-completion was attempted. This patch removes the call to `compinit` in the zsh completion output, causing no behavioral changes to the existing `completion` command, but fixing any issues that were caused after sourcing its output. --- pkg/kubectl/cmd/completion.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/kubectl/cmd/completion.go b/pkg/kubectl/cmd/completion.go index f7017daf667..64d11b9f964 100644 --- a/pkg/kubectl/cmd/completion.go +++ b/pkg/kubectl/cmd/completion.go @@ -234,7 +234,6 @@ __kubectl_quote() { fi } -autoload -U +X compinit && compinit autoload -U +X bashcompinit && bashcompinit # use word boundary patterns for BSD or GNU sed