github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-06 02:34:03 +00:00
Code Issues Projects Releases Wiki Activity

Added test case covering pending pods in syncJob

Browse Source
This commit is contained in:
Maciej Szulik 2016-07-07 14:45:34 +02:00
parent 8741217179
commit 79028c4e3b
1 changed files with 25 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
pkg/controller/job/controller_test.go
View File

@ -110,6 +110,7 @@ func TestControllerSyncJob(t *testing.T) {
// pod setup // pod setup
podControllerError error podControllerError error
pendingPods int32
activePods int32 activePods int32
succeededPods int32 succeededPods int32
failedPods int32 failedPods int32
@ -124,82 +125,87 @@ func TestControllerSyncJob(t *testing.T) {
}{ }{
"job start": { "job start": {
2, 5, 2, 5,
nil, 0, 0, 0, nil, 0, 0, 0, 0,
2, 0, 2, 0, 0, false, 2, 0, 2, 0, 0, false,
}, },
"WQ job start": { "WQ job start": {
2, -1, 2, -1,
nil, 0, 0, 0, nil, 0, 0, 0, 0,
2, 0, 2, 0, 0, false, 2, 0, 2, 0, 0, false,
}, },
"pending pods": {
2, 5,
nil, 2, 0, 0, 0,
0, 0, 2, 0, 0, false,
},
"correct # of pods": { "correct # of pods": {
2, 5, 2, 5,
nil, 2, 0, 0, nil, 0, 2, 0, 0,
0, 0, 2, 0, 0, false, 0, 0, 2, 0, 0, false,
}, },
"WQ job: correct # of pods": { "WQ job: correct # of pods": {
2, -1, 2, -1,
nil, 2, 0, 0, nil, 0, 2, 0, 0,
0, 0, 2, 0, 0, false, 0, 0, 2, 0, 0, false,
}, },
"too few active pods": { "too few active pods": {
2, 5, 2, 5,
nil, 1, 1, 0, nil, 0, 1, 1, 0,
1, 0, 2, 1, 0, false, 1, 0, 2, 1, 0, false,
}, },
"too few active pods with a dynamic job": { "too few active pods with a dynamic job": {
2, -1, 2, -1,
nil, 1, 0, 0, nil, 0, 1, 0, 0,
1, 0, 2, 0, 0, false, 1, 0, 2, 0, 0, false,
}, },
"too few active pods, with controller error": { "too few active pods, with controller error": {
2, 5, 2, 5,
fmt.Errorf("Fake error"), 1, 1, 0, fmt.Errorf("Fake error"), 0, 1, 1, 0,
0, 0, 1, 1, 0, false, 0, 0, 1, 1, 0, false,
}, },
"too many active pods": { "too many active pods": {
2, 5, 2, 5,
nil, 3, 0, 0, nil, 0, 3, 0, 0,
0, 1, 2, 0, 0, false, 0, 1, 2, 0, 0, false,
}, },
"too many active pods, with controller error": { "too many active pods, with controller error": {
2, 5, 2, 5,
fmt.Errorf("Fake error"), 3, 0, 0, fmt.Errorf("Fake error"), 0, 3, 0, 0,
0, 0, 3, 0, 0, false, 0, 0, 3, 0, 0, false,
}, },
"failed pod": { "failed pod": {
2, 5, 2, 5,
nil, 1, 1, 1, nil, 0, 1, 1, 1,
1, 0, 2, 1, 1, false, 1, 0, 2, 1, 1, false,
}, },
"job finish": { "job finish": {
2, 5, 2, 5,
nil, 0, 5, 0, nil, 0, 0, 5, 0,
0, 0, 0, 5, 0, true, 0, 0, 0, 5, 0, true,
}, },
"WQ job finishing": { "WQ job finishing": {
2, -1, 2, -1,
nil, 1, 1, 0, nil, 0, 1, 1, 0,
0, 0, 1, 1, 0, false, 0, 0, 1, 1, 0, false,
}, },
"WQ job all finished": { "WQ job all finished": {
2, -1, 2, -1,
nil, 0, 2, 0, nil, 0, 0, 2, 0,
0, 0, 0, 2, 0, true, 0, 0, 0, 2, 0, true,
}, },
"WQ job all finished despite one failure": { "WQ job all finished despite one failure": {
2, -1, 2, -1,
nil, 0, 1, 1, nil, 0, 0, 1, 1,
0, 0, 0, 1, 1, true, 0, 0, 0, 1, 1, true,
}, },
"more active pods than completions": { "more active pods than completions": {
2, 5, 2, 5,
nil, 10, 0, 0, nil, 0, 10, 0, 0,
0, 8, 2, 0, 0, false, 0, 8, 2, 0, 0, false,
}, },
"status change": { "status change": {
2, 5, 2, 5,
nil, 2, 2, 0, nil, 0, 2, 2, 0,
0, 0, 2, 2, 0, false, 0, 0, 2, 2, 0, false,
}, },
} }
@ -220,6 +226,9 @@ func TestControllerSyncJob(t *testing.T) {
// job & pods setup // job & pods setup
job := newJob(tc.parallelism, tc.completions) job := newJob(tc.parallelism, tc.completions)
manager.jobStore.Store.Add(job) manager.jobStore.Store.Add(job)
for _, pod := range newPodList(tc.pendingPods, api.PodPending, job) {
manager.podStore.Indexer.Add(&pod)
}
for _, pod := range newPodList(tc.activePods, api.PodRunning, job) { for _, pod := range newPodList(tc.activePods, api.PodRunning, job) {
manager.podStore.Indexer.Add(&pod) manager.podStore.Indexer.Add(&pod)
} }