github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 06:27:05 +00:00
Code Issues Projects Releases Wiki Activity

e2e framework: add BetaDefaultOff feature gate testcase

Browse Source
This commit is contained in:
Benjamin Elder 2025-03-19 15:36:47 -07:00
parent 507621e0da
commit 798ce5bde2
2 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/e2e/framework/internal/unittests/bugs/bugs.go
View File

@ -80,6 +80,7 @@ func Describe() {
framework.WithFeatureGate("no-such-feature-gate"), framework.WithFeatureGate("no-such-feature-gate"),
framework.WithFeatureGate(features.Alpha), framework.WithFeatureGate(features.Alpha),
framework.WithFeatureGate(features.Beta), framework.WithFeatureGate(features.Beta),
framework.WithFeatureGate(features.BetaDefaultOff),
framework.WithFeatureGate(features.GA), framework.WithFeatureGate(features.GA),
framework.WithConformance(), framework.WithConformance(),
framework.WithNodeConformance(), framework.WithNodeConformance(),
@ -116,14 +117,14 @@ ERROR: bugs.go:71: trailing or leading spaces are unnecessary and need to be rem
ERROR: bugs.go:76: WithFeature: unknown feature "no-such-feature" ERROR: bugs.go:76: WithFeature: unknown feature "no-such-feature"
ERROR: bugs.go:78: WithEnvironment: unknown environment "no-such-env" ERROR: bugs.go:78: WithEnvironment: unknown environment "no-such-env"
ERROR: bugs.go:80: WithFeatureGate: the feature gate "no-such-feature-gate" is unknown ERROR: bugs.go:80: WithFeatureGate: the feature gate "no-such-feature-gate" is unknown
ERROR: bugs.go:106: SIG label must be lowercase, no spaces and no sig- prefix, got instead: "123" ERROR: bugs.go:107: SIG label must be lowercase, no spaces and no sig- prefix, got instead: "123"
ERROR: buggy/buggy.go:100: hello world ERROR: buggy/buggy.go:100: hello world
ERROR: some/relative/path/buggy.go:200: with spaces ERROR: some/relative/path/buggy.go:200: with spaces
` `
// Used by unittests/list-tests. It's sorted by test name, not source code location. // Used by unittests/list-tests. It's sorted by test name, not source code location.
ListTestsOutput = `The following spec names can be used with 'ginkgo run --focus/skip': ListTestsOutput = `The following spec names can be used with 'ginkgo run --focus/skip':
../bugs/bugs.go:100: [sig-testing] abc space1 space2 [Feature:no-such-feature] [Feature:feature-foo] [Environment:no-such-env] [Environment:Linux] [FeatureGate:no-such-feature-gate] [Feature:OffByDefault] [FeatureGate:TestAlphaFeature] [Alpha] [Feature:OffByDefault] [FeatureGate:TestBetaFeature] [Beta] [FeatureGate:TestGAFeature] [Conformance] [NodeConformance] [Slow] [Serial] [Disruptive] [custom-label] xyz x [foo] should [bar] ../bugs/bugs.go:101: [sig-testing] abc space1 space2 [Feature:no-such-feature] [Feature:feature-foo] [Environment:no-such-env] [Environment:Linux] [FeatureGate:no-such-feature-gate] [Feature:OffByDefault] [FeatureGate:TestAlphaFeature] [Alpha] [Feature:OffByDefault] [FeatureGate:TestBetaFeature] [Beta] [FeatureGate:TestBetaDefaultOffFeature] [Beta] [Feature:OffByDefault] [FeatureGate:TestGAFeature] [Conformance] [NodeConformance] [Slow] [Serial] [Disruptive] [custom-label] xyz x [foo] should [bar]
../bugs/bugs.go:95: [sig-testing] abc space1 space2 [Feature:no-such-feature] [Feature:feature-foo] [Environment:no-such-env] [Environment:Linux] [FeatureGate:no-such-feature-gate] [Feature:OffByDefault] [FeatureGate:TestAlphaFeature] [Alpha] [Feature:OffByDefault] [FeatureGate:TestBetaFeature] [Beta] [FeatureGate:TestGAFeature] [Conformance] [NodeConformance] [Slow] [Serial] [Disruptive] [custom-label] xyz y [foo] should [bar] ../bugs/bugs.go:96: [sig-testing] abc space1 space2 [Feature:no-such-feature] [Feature:feature-foo] [Environment:no-such-env] [Environment:Linux] [FeatureGate:no-such-feature-gate] [Feature:OffByDefault] [FeatureGate:TestAlphaFeature] [Alpha] [Feature:OffByDefault] [FeatureGate:TestBetaFeature] [Beta] [FeatureGate:TestBetaDefaultOffFeature] [Beta] [Feature:OffByDefault] [FeatureGate:TestGAFeature] [Conformance] [NodeConformance] [Slow] [Serial] [Disruptive] [custom-label] xyz y [foo] should [bar]
` `
@ -140,6 +141,7 @@ ERROR: some/relative/path/buggy.go:200: with spaces
Feature:feature-foo Feature:feature-foo
Feature:no-such-feature Feature:no-such-feature
FeatureGate:TestAlphaFeature FeatureGate:TestAlphaFeature
FeatureGate:TestBetaDefaultOffFeature
FeatureGate:TestBetaFeature FeatureGate:TestBetaFeature
FeatureGate:TestGAFeature FeatureGate:TestGAFeature
FeatureGate:no-such-feature-gate FeatureGate:no-such-feature-gate

10
test/e2e/framework/internal/unittests/bugs/features/features.go
View File

@ -24,9 +24,10 @@ import (
) )
const ( const (
Alpha featuregate.Feature = "TestAlphaFeature" Alpha featuregate.Feature = "TestAlphaFeature"
Beta featuregate.Feature = "TestBetaFeature" Beta featuregate.Feature = "TestBetaFeature"
GA featuregate.Feature = "TestGAFeature" BetaDefaultOff featuregate.Feature = "TestBetaDefaultOffFeature"
GA featuregate.Feature = "TestGAFeature"
) )
func init() { func init() {
@ -41,6 +42,9 @@ var testFeatureGates = map[featuregate.Feature]featuregate.VersionedSpecs{
{Version: version.MustParse("1.27"), Default: false, PreRelease: featuregate.Alpha}, {Version: version.MustParse("1.27"), Default: false, PreRelease: featuregate.Alpha},
{Version: version.MustParse("1.28"), Default: true, PreRelease: featuregate.Beta}, {Version: version.MustParse("1.28"), Default: true, PreRelease: featuregate.Beta},
}, },
BetaDefaultOff: {
{Version: version.MustParse("1.28"), Default: false, PreRelease: featuregate.Beta},
},
GA: { GA: {
{Version: version.MustParse("1.27"), Default: false, PreRelease: featuregate.Alpha}, {Version: version.MustParse("1.27"), Default: false, PreRelease: featuregate.Alpha},
{Version: version.MustParse("1.28"), Default: true, PreRelease: featuregate.Beta}, {Version: version.MustParse("1.28"), Default: true, PreRelease: featuregate.Beta},