From 7a5e7030d216ee647de828f81ca4342beb651468 Mon Sep 17 00:00:00 2001 From: Ted Yu Date: Mon, 8 Jul 2019 17:40:59 -0700 Subject: [PATCH] Handle error return from http.NewRequest() --- pkg/credentialprovider/azure/azure_acr_helper.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/pkg/credentialprovider/azure/azure_acr_helper.go b/pkg/credentialprovider/azure/azure_acr_helper.go index be18de4cec1..a8604b0e261 100644 --- a/pkg/credentialprovider/azure/azure_acr_helper.go +++ b/pkg/credentialprovider/azure/azure_acr_helper.go @@ -84,7 +84,10 @@ func receiveChallengeFromLoginServer(serverAddress string) (*authDirective, erro } var err error var r *http.Request - r, _ = http.NewRequest("GET", challengeURL.String(), nil) + r, err = http.NewRequest("GET", challengeURL.String(), nil) + if err != nil { + return nil, fmt.Errorf("failed to construct request, got %v", err) + } r.Header.Add(userAgentHeader, userAgent) var challenge *http.Response @@ -154,7 +157,10 @@ func performTokenExchange( datac := data.Encode() var r *http.Request - r, _ = http.NewRequest("POST", authEndpoint, bytes.NewBufferString(datac)) + r, err = http.NewRequest("POST", authEndpoint, bytes.NewBufferString(datac)) + if err != nil { + return "", fmt.Errorf("failed to construct request, got %v", err) + } r.Header.Add(userAgentHeader, userAgent) r.Header.Add("Content-Type", "application/x-www-form-urlencoded") r.Header.Add("Content-Length", strconv.Itoa(len(datac)))