From 7ad0e451aca6bd3f65638b03365a6cd270cd98c3 Mon Sep 17 00:00:00 2001 From: Benjamin Elder Date: Mon, 11 Sep 2023 14:06:28 -0700 Subject: [PATCH] remove unnecessary kube::golang::verify_go_version calls These scripts don't use go, GOPATH, etc. They only need to cd to KUBE_ROOT and run git/grep. verify_go_version is wasting time. --- hack/verify-pkg-names.sh | 2 -- hack/verify-prerelease-lifecycle-tags.sh | 2 -- 2 files changed, 4 deletions(-) diff --git a/hack/verify-pkg-names.sh b/hack/verify-pkg-names.sh index 37b7750355d..c9904ff980b 100755 --- a/hack/verify-pkg-names.sh +++ b/hack/verify-pkg-names.sh @@ -24,8 +24,6 @@ set -o pipefail KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/.. source "${KUBE_ROOT}/hack/lib/init.sh" -kube::golang::verify_go_version - cd "${KUBE_ROOT}" if git --no-pager grep -E $'^(import |\t)[a-z]+[A-Z_][a-zA-Z]* "[^"]+"$' -- '**/*.go' ':(exclude)vendor/*' ':(exclude)**/*.pb.go'; then echo "!!! Some package aliases break go conventions." diff --git a/hack/verify-prerelease-lifecycle-tags.sh b/hack/verify-prerelease-lifecycle-tags.sh index 965f4f03f6c..369823bf345 100755 --- a/hack/verify-prerelease-lifecycle-tags.sh +++ b/hack/verify-prerelease-lifecycle-tags.sh @@ -24,8 +24,6 @@ set -o pipefail KUBE_ROOT=$(dirname "${BASH_SOURCE[0]}")/.. source "${KUBE_ROOT}/hack/lib/init.sh" -kube::golang::verify_go_version - cd "${KUBE_ROOT}" if git --no-pager grep -L '// +k8s:prerelease-lifecycle-gen=true' -- 'staging/src/k8s.io/api/**/*beta*/doc.go'; then echo "!!! Some beta packages doc.go do not include prerelease-lifecycle tags."