When splitting snake_case words, omit the underscore

While we require camelCase by convention for official APIs, CRDs may use
`snake_case`, and the generic describer prints this as `Snake _ Case`.

Prow is impacted by this for the ProwJob CRD:

```
  Decoration _ Config:
    Gcs _ Configuration:
      Bucket:                    origin-ci-test
      Default _ Org:             openshift
      Default _ Repo:            origin
      Path _ Strategy:           single
    Gcs _ Credentials _ Secret:  gcs-publisher-credentials
```
This commit is contained in:
Clayton Coleman
2018-06-22 20:00:49 -04:00
parent 5e9a5659b7
commit 7ae6664171

View File

@@ -275,19 +275,22 @@ func printUnstructuredContent(w PrefixWriter, level int, content map[string]inte
func smartLabelFor(field string) string { func smartLabelFor(field string) string {
commonAcronyms := []string{"API", "URL", "UID", "OSB", "GUID"} commonAcronyms := []string{"API", "URL", "UID", "OSB", "GUID"}
splitted := camelcase.Split(field) parts := camelcase.Split(field)
for i := 0; i < len(splitted); i++ { result := make([]string, 0, len(parts))
part := splitted[i] for _, part := range parts {
if part == "_" {
continue
}
if slice.ContainsString(commonAcronyms, strings.ToUpper(part), nil) { if slice.ContainsString(commonAcronyms, strings.ToUpper(part), nil) {
part = strings.ToUpper(part) part = strings.ToUpper(part)
} else { } else {
part = strings.Title(part) part = strings.Title(part)
} }
splitted[i] = part result = append(result, part)
} }
return strings.Join(splitted, " ") return strings.Join(result, " ")
} }
// DefaultObjectDescriber can describe the default Kubernetes objects. // DefaultObjectDescriber can describe the default Kubernetes objects.