From 7b54199fd5efcec65ba76076455fd5b6fe4e865b Mon Sep 17 00:00:00 2001 From: Alexander Campbell Date: Thu, 25 May 2017 13:38:23 -0700 Subject: [PATCH] kubectl: note a bug with a comment This doesn't seem to be affecting anything and I'm not sure what the correct behavior needs to be here. I'll highlight this in the code review and hopefully work out a correct solution with the help of the reviewers. --- pkg/kubectl/stop.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/kubectl/stop.go b/pkg/kubectl/stop.go index c75fe03f749..86510ac02af 100644 --- a/pkg/kubectl/stop.go +++ b/pkg/kubectl/stop.go @@ -332,6 +332,8 @@ func (reaper *StatefulSetReaper) Stop(namespace, name string, timeout time.Durat } if timeout == 0 { numReplicas := ss.Spec.Replicas + + // BUG: this timeout is never used. timeout = Timeout + time.Duration(10*numReplicas)*time.Second } retry := NewRetryParams(reaper.pollInterval, reaper.timeout)