github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-08 12:41:58 +00:00
Code Issues Projects Releases Wiki Activity

volume: improve test coverage and minor refactoring

Browse Source 
The volume package does not test enough use-cases.

Improve test coverage by adding additional tests and refactoring
current tests to use table testing.

This change introduces a new error var to make testing unsupported
volume type errors easier.

This change does not introduce any changes in behavior.
This commit is contained in:
Kelsey Hightower
2014-07-27 11:38:35 -07:00
parent ab91e074d8
commit 7b59845843
2 changed files with 75 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/volume/volume.go
View File

@@ -24,16 +24,18 @@ import (
"github.com/GoogleCloudPlatform/kubernetes/pkg/api"
)
// All volume types are expected to implement this interface
var ErrUnsupportedVolumeType = errors.New("unsupported volume type")
// Interface is a directory used by pods or hosts. Interface implementations
// must be idempotent.
type Interface interface {
// Prepares and mounts/unpacks the volume to a directory path.
// This procedure must be idempotent.
// TODO(jonesdl) SetUp should return an error if it fails.
// SetUp prepares and mounts/unpacks the volume to a directory path.
SetUp() error
// Returns the directory path the volume is mounted to.
// GetPath returns the directory path the volume is mounted to.
GetPath() string
// Unmounts the volume and removes traces of the SetUp procedure.
// This procedure must be idempotent.
// TearDown unmounts the volume and removes traces of the SetUp procedure.
TearDown() error
}
@@ -112,7 +114,7 @@ func CreateVolume(volume *api.Volume, podID string, rootDir string) (Interface,
} else if source.EmptyDirectory != nil {
vol = createEmptyDirectory(volume, podID, rootDir)
} else {
return nil, errors.New("Unsupported volume type.")
return nil, ErrUnsupportedVolumeType
}
return vol, nil
}