From 7b8d711d0255be17de4e6e6918e8e03120af6ab9 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Thu, 31 Mar 2022 11:16:34 +0200 Subject: [PATCH] json: clarify magic 100 constant This addresses review feedback from https://github.com/kubernetes/kubernetes/pull/108995#discussion_r837943366. --- staging/src/k8s.io/component-base/logs/json/klog_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/staging/src/k8s.io/component-base/logs/json/klog_test.go b/staging/src/k8s.io/component-base/logs/json/klog_test.go index c5f0ae7719b..3358db88d45 100644 --- a/staging/src/k8s.io/component-base/logs/json/klog_test.go +++ b/staging/src/k8s.io/component-base/logs/json/klog_test.go @@ -28,6 +28,7 @@ import ( "github.com/stretchr/testify/assert" "go.uber.org/zap/zapcore" + "k8s.io/component-base/config" "k8s.io/klog/v2" ) @@ -239,7 +240,9 @@ func TestKlogIntegration(t *testing.T) { t.Run(tc.name, func(t *testing.T) { var buffer bytes.Buffer writer := zapcore.AddSync(&buffer) - logger, _ := NewJSONLogger(100, writer, nil, nil) + // This level is high enough to enable all log messages from this test. + verbosityLevel := config.VerbosityLevel(100) + logger, _ := NewJSONLogger(verbosityLevel, writer, nil, nil) klog.SetLogger(logger) defer klog.ClearLogger()