github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-12 05:21:58 +00:00
Code Issues Projects Releases Wiki Activity

API warn ExternalName services with externalIPs

Browse Source
This commit is contained in:
Tim Hockin 2023-07-13 18:39:51 -07:00
parent a6776f4e39
commit 7bd0a857e3
No known key found for this signature in database
2 changed files with 22 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/api/service/warnings.go
View File

@ -53,6 +53,10 @@ func GetWarningsForService(service, oldService *api.Service) []string {
warnings = append(warnings, getWarningsForCIDR(field.NewPath("spec").Child("loadBalancerSourceRanges").Index(i), cidr)...) warnings = append(warnings, getWarningsForCIDR(field.NewPath("spec").Child("loadBalancerSourceRanges").Index(i), cidr)...)
} }
if service.Spec.Type == api.ServiceTypeExternalName && len(service.Spec.ExternalIPs) > 0 {
warnings = append(warnings, fmt.Sprintf("spec.externalIPs is ignored when spec.type is %q", api.ServiceTypeExternalName))
}
return warnings return warnings
} }

32
pkg/api/service/warnings_test.go
View File

@ -31,22 +31,26 @@ func TestGetWarningsForService(t *testing.T) {
name string name string
tweakSvc func(svc *api.Service) // Given a basic valid service, each test case can customize it. tweakSvc func(svc *api.Service) // Given a basic valid service, each test case can customize it.
numWarnings int numWarnings int
}{ }{{
{ name: "new topology mode set",
name: "new topology mode set", tweakSvc: func(s *api.Service) {
tweakSvc: func(s *api.Service) { s.Annotations = map[string]string{api.AnnotationTopologyMode: "foo"}
s.Annotations = map[string]string{api.AnnotationTopologyMode: "foo"}
},
numWarnings: 0,
}, },
{ numWarnings: 0,
name: "deprecated hints annotation set", }, {
tweakSvc: func(s *api.Service) { name: "deprecated hints annotation set",
s.Annotations = map[string]string{api.DeprecatedAnnotationTopologyAwareHints: "foo"} tweakSvc: func(s *api.Service) {
}, s.Annotations = map[string]string{api.DeprecatedAnnotationTopologyAwareHints: "foo"}
numWarnings: 1,
}, },
} numWarnings: 1,
}, {
name: "externalIPs set when type is ExternalName",
tweakSvc: func(s *api.Service) {
s.Spec.Type = api.ServiceTypeExternalName
s.Spec.ExternalIPs = []string{"1.2.3.4"}
},
numWarnings: 1,
}}
for _, tc := range testCases { for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) { t.Run(tc.name, func(t *testing.T) {