From fafd1df7a6fce252c491a5fac77b1caa470ff229 Mon Sep 17 00:00:00 2001 From: Jeff Grafton Date: Mon, 20 Apr 2015 11:59:18 -0700 Subject: [PATCH] Revert "Continue after failed unit test" This reverts commit f70752d9e1d1130f8bf083e744ac401e769fe49b. This change caused Travis and Shippable to report success on all test runs, even if any tests failed or timed out. --- hack/test-go.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hack/test-go.sh b/hack/test-go.sh index 70b834f4d72..f2d787950ab 100755 --- a/hack/test-go.sh +++ b/hack/test-go.sh @@ -151,7 +151,7 @@ runTests() { if [[ ! ${KUBE_COVER} =~ ^[yY]$ ]]; then kube::log::status "Running unit tests without code coverage" go test "${goflags[@]:+${goflags[@]}}" \ - ${KUBE_RACE} ${KUBE_TIMEOUT} "${@+${@/#/${KUBE_GO_PACKAGE}/}}" || true + ${KUBE_RACE} ${KUBE_TIMEOUT} "${@+${@/#/${KUBE_GO_PACKAGE}/}}" return 0 fi @@ -173,7 +173,7 @@ runTests() { -cover -covermode="${KUBE_COVERMODE}" \ -coverprofile="${cover_report_dir}/{}/${cover_profile}" \ "${cover_params[@]+${cover_params[@]}}" \ - "${KUBE_GO_PACKAGE}/{}" || true + "${KUBE_GO_PACKAGE}/{}" COMBINED_COVER_PROFILE="${cover_report_dir}/combined-coverage.out" {