diff --git a/pkg/kubelet/server/BUILD b/pkg/kubelet/server/BUILD index 0d8138acf2d..c2e338a1ad8 100644 --- a/pkg/kubelet/server/BUILD +++ b/pkg/kubelet/server/BUILD @@ -26,7 +26,6 @@ go_library( "//pkg/kubelet/server/streaming:go_default_library", "//pkg/kubelet/types:go_default_library", "//pkg/util/configz:go_default_library", - "//pkg/util/limitwriter:go_default_library", "//vendor/github.com/emicklei/go-restful:go_default_library", "//vendor/github.com/golang/glog:go_default_library", "//vendor/github.com/google/cadvisor/info/v1:go_default_library", diff --git a/pkg/kubelet/server/server.go b/pkg/kubelet/server/server.go index b472015e148..fdde1fee4e8 100644 --- a/pkg/kubelet/server/server.go +++ b/pkg/kubelet/server/server.go @@ -61,7 +61,6 @@ import ( "k8s.io/kubernetes/pkg/kubelet/server/streaming" kubelettypes "k8s.io/kubernetes/pkg/kubelet/types" "k8s.io/kubernetes/pkg/util/configz" - "k8s.io/kubernetes/pkg/util/limitwriter" ) const ( @@ -532,17 +531,9 @@ func (s *Server) getContainerLogs(request *restful.Request, response *restful.Re return } fw := flushwriter.Wrap(response.ResponseWriter) - // Byte limit logic is already implemented in kuberuntime. However, we still need this for - // old runtime integration. - // TODO(random-liu): Remove this once we switch to CRI integration. - if logOptions.LimitBytes != nil { - fw = limitwriter.New(fw, *logOptions.LimitBytes) - } response.Header().Set("Transfer-Encoding", "chunked") if err := s.host.GetKubeletContainerLogs(kubecontainer.GetPodFullName(pod), containerName, logOptions, fw, fw); err != nil { - if err != limitwriter.ErrMaximumWrite { - response.WriteError(http.StatusBadRequest, err) - } + response.WriteError(http.StatusBadRequest, err) return } } diff --git a/pkg/kubelet/server/server_test.go b/pkg/kubelet/server/server_test.go index b5169de1a7c..cdb978078cf 100644 --- a/pkg/kubelet/server/server_test.go +++ b/pkg/kubelet/server/server_test.go @@ -943,33 +943,6 @@ func TestContainerLogs(t *testing.T) { } } -func TestContainerLogsWithLimitBytes(t *testing.T) { - fw := newServerTest() - defer fw.testHTTPServer.Close() - output := "foo bar" - podNamespace := "other" - podName := "foo" - expectedPodName := getPodName(podName, podNamespace) - expectedContainerName := "baz" - bytes := int64(3) - setPodByNameFunc(fw, podNamespace, podName, expectedContainerName) - setGetContainerLogsFunc(fw, t, expectedPodName, expectedContainerName, &v1.PodLogOptions{LimitBytes: &bytes}, output) - resp, err := http.Get(fw.testHTTPServer.URL + "/containerLogs/" + podNamespace + "/" + podName + "/" + expectedContainerName + "?limitBytes=3") - if err != nil { - t.Errorf("Got error GETing: %v", err) - } - defer resp.Body.Close() - - body, err := ioutil.ReadAll(resp.Body) - if err != nil { - t.Errorf("Error reading container logs: %v", err) - } - result := string(body) - if result != output[:bytes] { - t.Errorf("Expected: '%v', got: '%v'", output[:bytes], result) - } -} - func TestContainerLogsWithTail(t *testing.T) { fw := newServerTest() defer fw.testHTTPServer.Close()