diff --git a/pkg/scheduler/framework/plugins/nodevolumelimits/csi_test.go b/pkg/scheduler/framework/plugins/nodevolumelimits/csi_test.go index e74d781a321..1207176abc5 100644 --- a/pkg/scheduler/framework/plugins/nodevolumelimits/csi_test.go +++ b/pkg/scheduler/framework/plugins/nodevolumelimits/csi_test.go @@ -281,7 +281,7 @@ func TestCSILimits(t *testing.T) { existingPods []*v1.Pod extraClaims []v1.PersistentVolumeClaim filterName string - maxVols int + maxVols int32 driverNames []string test string migrationEnabled bool @@ -613,7 +613,7 @@ func TestCSILimits(t *testing.T) { // running attachable predicate tests with feature gate and limit present on nodes for _, test := range tests { t.Run(test.test, func(t *testing.T) { - node, csiNode := getNodeWithPodAndVolumeLimits(test.limitSource, test.existingPods, int64(test.maxVols), test.driverNames...) + node, csiNode := getNodeWithPodAndVolumeLimits(test.limitSource, test.existingPods, test.maxVols, test.driverNames...) if csiNode != nil { enableMigrationOnNode(csiNode, csilibplugins.AWSEBSInTreePluginName) } @@ -746,7 +746,7 @@ func getFakeCSINodeLister(csiNode *storagev1.CSINode) tf.CSINodeLister { return csiNodeLister } -func getNodeWithPodAndVolumeLimits(limitSource string, pods []*v1.Pod, limit int64, driverNames ...string) (*framework.NodeInfo, *storagev1.CSINode) { +func getNodeWithPodAndVolumeLimits(limitSource string, pods []*v1.Pod, limit int32, driverNames ...string) (*framework.NodeInfo, *storagev1.CSINode) { nodeInfo := framework.NewNodeInfo(pods...) node := &v1.Node{ ObjectMeta: metav1.ObjectMeta{Name: "node-for-max-pd-test-1"}, @@ -758,7 +758,7 @@ func getNodeWithPodAndVolumeLimits(limitSource string, pods []*v1.Pod, limit int addLimitToNode := func() { for _, driver := range driverNames { - node.Status.Allocatable[getVolumeLimitKey(driver)] = *resource.NewQuantity(limit, resource.DecimalSI) + node.Status.Allocatable[getVolumeLimitKey(driver)] = *resource.NewQuantity(int64(limit), resource.DecimalSI) } } @@ -780,7 +780,7 @@ func getNodeWithPodAndVolumeLimits(limitSource string, pods []*v1.Pod, limit int } if addLimits { driver.Allocatable = &storagev1.VolumeNodeResources{ - Count: ptr.To(int32(limit)), + Count: ptr.To(limit), } } csiNode.Spec.Drivers = append(csiNode.Spec.Drivers, driver) diff --git a/pkg/scheduler/framework/plugins/nodevolumelimits/non_csi_test.go b/pkg/scheduler/framework/plugins/nodevolumelimits/non_csi_test.go index 776849d4783..2b8f99c37f2 100644 --- a/pkg/scheduler/framework/plugins/nodevolumelimits/non_csi_test.go +++ b/pkg/scheduler/framework/plugins/nodevolumelimits/non_csi_test.go @@ -129,7 +129,7 @@ func TestEphemeralLimits(t *testing.T) { existingPods []*v1.Pod extraClaims []v1.PersistentVolumeClaim ephemeralEnabled bool - maxVols int + maxVols int32 test string wantStatus *framework.Status wantPreFilterStatus *framework.Status @@ -182,7 +182,7 @@ func TestEphemeralLimits(t *testing.T) { for _, test := range tests { t.Run(test.test, func(t *testing.T) { fts := feature.Features{} - node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, int64(test.maxVols), filterName) + node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, test.maxVols, filterName) p := newNonCSILimits(filterName, getFakeCSINodeLister(csiNode), getFakeCSIStorageClassLister(filterName, driverName), getFakePVLister(filterName), append(getFakePVCLister(filterName), test.extraClaims...), fts).(framework.FilterPlugin) _, gotPreFilterStatus := p.(*nonCSILimits).PreFilter(context.Background(), nil, test.newPod) if diff := cmp.Diff(test.wantPreFilterStatus, gotPreFilterStatus); diff != "" { @@ -241,7 +241,7 @@ func TestAzureDiskLimits(t *testing.T) { existingPods []*v1.Pod filterName string driverName string - maxVols int + maxVols int32 test string wantStatus *framework.Status wantPreFilterStatus *framework.Status @@ -412,7 +412,7 @@ func TestAzureDiskLimits(t *testing.T) { for _, test := range tests { t.Run(test.test, func(t *testing.T) { - node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, int64(test.maxVols), test.filterName) + node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, test.maxVols, test.filterName) p := newNonCSILimits(test.filterName, getFakeCSINodeLister(csiNode), getFakeCSIStorageClassLister(test.filterName, test.driverName), getFakePVLister(test.filterName), getFakePVCLister(test.filterName), feature.Features{}).(framework.FilterPlugin) _, gotPreFilterStatus := p.(*nonCSILimits).PreFilter(context.Background(), nil, test.newPod) if diff := cmp.Diff(test.wantPreFilterStatus, gotPreFilterStatus); diff != "" { @@ -476,7 +476,7 @@ func TestEBSLimits(t *testing.T) { existingPods []*v1.Pod filterName string driverName string - maxVols int + maxVols int32 test string wantStatus *framework.Status wantPreFilterStatus *framework.Status @@ -693,7 +693,7 @@ func TestEBSLimits(t *testing.T) { for _, test := range tests { t.Run(test.test, func(t *testing.T) { - node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, int64(test.maxVols), test.filterName) + node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, test.maxVols, test.filterName) p := newNonCSILimits(test.filterName, getFakeCSINodeLister(csiNode), getFakeCSIStorageClassLister(test.filterName, test.driverName), getFakePVLister(test.filterName), getFakePVCLister(test.filterName), feature.Features{}).(framework.FilterPlugin) _, gotPreFilterStatus := p.(*nonCSILimits).PreFilter(context.Background(), nil, test.newPod) if diff := cmp.Diff(test.wantPreFilterStatus, gotPreFilterStatus); diff != "" { @@ -752,7 +752,7 @@ func TestGCEPDLimits(t *testing.T) { existingPods []*v1.Pod filterName string driverName string - maxVols int + maxVols int32 test string wantStatus *framework.Status wantPreFilterStatus *framework.Status @@ -923,7 +923,7 @@ func TestGCEPDLimits(t *testing.T) { for _, test := range tests { t.Run(test.test, func(t *testing.T) { - node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, int64(test.maxVols), test.filterName) + node, csiNode := getNodeWithPodAndVolumeLimits("node", test.existingPods, test.maxVols, test.filterName) p := newNonCSILimits(test.filterName, getFakeCSINodeLister(csiNode), getFakeCSIStorageClassLister(test.filterName, test.driverName), getFakePVLister(test.filterName), getFakePVCLister(test.filterName), feature.Features{}).(framework.FilterPlugin) _, gotPreFilterStatus := p.(*nonCSILimits).PreFilter(context.Background(), nil, test.newPod) if diff := cmp.Diff(test.wantPreFilterStatus, gotPreFilterStatus); diff != "" {