Merge pull request #106565 from kerthcet/feature/addd-several-testcases-to-cover-priority-admission

add several testcases to cover PriorityClass admission veeifications
This commit is contained in:
Kubernetes Prow Robot 2022-03-03 10:43:48 -08:00 committed by GitHub
commit 7c6f09e4b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -140,29 +140,75 @@ func TestPriorityClassAdmission(t *testing.T) {
existingClasses []*scheduling.PriorityClass existingClasses []*scheduling.PriorityClass
newClass *scheduling.PriorityClass newClass *scheduling.PriorityClass
userInfo user.Info userInfo user.Info
operation admission.Operation
expectError bool expectError bool
}{ }{
{ {
"one default class", "create operator with default class",
[]*scheduling.PriorityClass{}, []*scheduling.PriorityClass{},
defaultClass1, defaultClass1,
nil, nil,
admission.Create,
false, false,
}, },
{ {
"more than one default classes", "create operator with one existing default class",
[]*scheduling.PriorityClass{defaultClass1}, []*scheduling.PriorityClass{defaultClass1},
defaultClass2, defaultClass2,
nil, nil,
admission.Create,
true, true,
}, },
{ {
"system name and value are allowed by admission controller", "create operator with system name and value allowed by admission controller",
[]*scheduling.PriorityClass{}, []*scheduling.PriorityClass{},
systemClass, systemClass,
&user.DefaultInfo{ &user.DefaultInfo{
Name: user.APIServerUser, Name: user.APIServerUser,
}, },
admission.Create,
false,
},
{
"update operator with default class",
[]*scheduling.PriorityClass{},
defaultClass1,
nil,
admission.Update,
false,
},
{
"update operator with one existing default class",
[]*scheduling.PriorityClass{defaultClass1},
defaultClass2,
nil,
admission.Update,
true,
},
{
"update operator with system name and value allowed by admission controller",
[]*scheduling.PriorityClass{},
systemClass,
&user.DefaultInfo{
Name: user.APIServerUser,
},
admission.Update,
false,
},
{
"update operator with different default classes",
[]*scheduling.PriorityClass{defaultClass1},
defaultClass2,
nil,
admission.Update,
true,
},
{
"delete operation with default class",
[]*scheduling.PriorityClass{},
defaultClass1,
nil,
admission.Delete,
false, false,
}, },
} }
@ -184,7 +230,7 @@ func TestPriorityClassAdmission(t *testing.T) {
"", "",
scheduling.Resource("priorityclasses").WithVersion("version"), scheduling.Resource("priorityclasses").WithVersion("version"),
"", "",
admission.Create, test.operation,
&metav1.CreateOptions{}, &metav1.CreateOptions{},
false, false,
test.userInfo, test.userInfo,