Merge pull request #120978 from tengqm/fix-admission-validation

Fixs a validation error in teh admission registration API
This commit is contained in:
Kubernetes Prow Robot 2023-10-15 22:58:39 +02:00 committed by GitHub
commit 7c876d8757
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -854,10 +854,10 @@ func validateMatchResources(mc *admissionregistration.MatchResources, fldPath *f
} }
if mc.ObjectSelector == nil { if mc.ObjectSelector == nil {
allErrors = append(allErrors, field.Required(fldPath.Child("labelSelector"), "")) allErrors = append(allErrors, field.Required(fldPath.Child("objectSelector"), ""))
} else { } else {
// validate selector strictly, this type was released after issue #99139 was resolved // validate selector strictly, this type was released after issue #99139 was resolved
allErrors = append(allErrors, metav1validation.ValidateLabelSelector(mc.ObjectSelector, metav1validation.LabelSelectorValidationOptions{}, fldPath.Child("labelSelector"))...) allErrors = append(allErrors, metav1validation.ValidateLabelSelector(mc.ObjectSelector, metav1validation.LabelSelectorValidationOptions{}, fldPath.Child("objectSelector"))...)
} }
for i, namedRuleWithOperations := range mc.ResourceRules { for i, namedRuleWithOperations := range mc.ResourceRules {