From 9baaeba435d7e5252e612efc2d4aea05b39db51f Mon Sep 17 00:00:00 2001 From: Diego Pontoriero Date: Mon, 21 Aug 2017 23:05:27 -0700 Subject: [PATCH] daemon_controller: fix typo. With the existing code, some edge cases might lead to the wrong pods being deleted. --- pkg/controller/daemon/daemon_controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/daemon/daemon_controller.go b/pkg/controller/daemon/daemon_controller.go index 7f7674be6d2..caff034891c 100644 --- a/pkg/controller/daemon/daemon_controller.go +++ b/pkg/controller/daemon/daemon_controller.go @@ -854,7 +854,7 @@ func (dsc *DaemonSetsController) manage(ds *extensions.DaemonSet, hash string) e if len(daemonPodsRunning) > 1 { sort.Sort(podByCreationTimestamp(daemonPodsRunning)) for i := 1; i < len(daemonPodsRunning); i++ { - podsToDelete = append(podsToDelete, daemonPods[i].Name) + podsToDelete = append(podsToDelete, daemonPodsRunning[i].Name) } } case !shouldContinueRunning && exists: