github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-29 06:27:05 +00:00
Code Issues Projects Releases Wiki Activity

Fix truncated logfile in verify-vendor

Browse Source 
Writing to /dev/stderr causes a new FD to be opened.  If this is a
literal file, that file can get truncated.  `>&2` does not suffer the
same problem.
This commit is contained in:
Tim Hockin 2020-05-07 21:46:33 -07:00
parent 04c2b1fbdc
commit 7cbef7b26f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hack/update-vendor-licenses.sh
View File

@ -187,11 +187,11 @@ fi
# Loop through every vendored package # Loop through every vendored package
for PACKAGE in $(go list -m -json all | jq -r .Path | sort -f); do for PACKAGE in $(go list -m -json all | jq -r .Path | sort -f); do
if [[ -e "staging/src/${PACKAGE}" ]]; then if [[ -e "staging/src/${PACKAGE}" ]]; then
echo "${PACKAGE} is a staging package, skipping" > /dev/stderr echo "${PACKAGE} is a staging package, skipping" >&2
continue continue
fi fi
if [[ ! -e "${DEPS_DIR}/${PACKAGE}" ]]; then if [[ ! -e "${DEPS_DIR}/${PACKAGE}" ]]; then
echo "${PACKAGE} doesn't exist in ${DEPS_DIR}, skipping" > /dev/stderr echo "${PACKAGE} doesn't exist in ${DEPS_DIR}, skipping" >&2
continue continue
fi fi
echo "${PACKAGE}" echo "${PACKAGE}"
@ -214,7 +214,7 @@ for PACKAGE in $(go list -m -json all | jq -r .Path | sort -f); do
file="${CONTENT[${PACKAGE}-COPYING]-}" file="${CONTENT[${PACKAGE}-COPYING]-}"
fi fi
if [[ -z "${file}" ]]; then if [[ -z "${file}" ]]; then
cat > /dev/stderr << __EOF__ cat >&2 << __EOF__
No license could be found for ${PACKAGE} - aborting. No license could be found for ${PACKAGE} - aborting.
Options: Options: