Merge pull request #114514 from jiahuif-forks/tests/validating-admission-policy

initial e2e tests for ValidatingAdmissionPolicy

test/e2e/apimachinery/validatingadmissionpolicy.go

@@ -0,0 +1,261 @@
+/*
+Copyright 2022 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package apimachinery
+
+import (
+	"context"
+	"fmt"
+	"time"
+
+	"github.com/onsi/ginkgo/v2"
+
+	admissionregistrationv1 "k8s.io/api/admissionregistration/v1"
+	admissionregistrationv1alpha1 "k8s.io/api/admissionregistration/v1alpha1"
+	appsv1 "k8s.io/api/apps/v1"
+	v1 "k8s.io/api/core/v1"
+	apierrors "k8s.io/apimachinery/pkg/api/errors"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/util/wait"
+	clientset "k8s.io/client-go/kubernetes"
+	"k8s.io/kubernetes/test/e2e/framework"
+	admissionapi "k8s.io/pod-security-admission/api"
+)
+
+var _ = SIGDescribe("ValidatingAdmissionPolicy [Privileged:ClusterAdmin][Alpha][Feature:ValidatingAdmissionPolicy]", func() {
+	f := framework.NewDefaultFramework("validating-admission-policy")
+	f.NamespacePodSecurityEnforceLevel = admissionapi.LevelBaseline
+
+	var client clientset.Interface
+
+	ginkgo.BeforeEach(func() {
+		var err error
+		client, err = clientset.NewForConfig(f.ClientConfig())
+		framework.ExpectNoError(err, "initializing client")
+		_, err = client.AdmissionregistrationV1alpha1().ValidatingAdmissionPolicies().List(context.Background(), metav1.ListOptions{})
+		if apierrors.IsNotFound(err) {
+			// TODO: feature check should fail after GA graduation
+			ginkgo.Skip(fmt.Sprintf("server does not support ValidatingAdmissionPolicy v1alpha1: %v, feature gate not enabled?", err))
+		}
+	})
+
+	ginkgo.BeforeEach(func(ctx context.Context) {
+		// Make sure the namespace created for the test is labeled to be selected
+		// in binding.spec.matchResources.namespaceSelector.matchLabels
+		// By containing the tests within the marked namespace, they will not
+		// disturb concurrent tests that run in other namespaces.
+		labelNamespace(ctx, f, f.Namespace.Name)
+	})
+
+	ginkgo.It("should validate against a Deployment", func(ctx context.Context) {
+		ginkgo.By("creating the policy", func() {
+			policy := newValidatingAdmissionPolicyBuilder(f.UniqueName+".policy.example.com").
+				MatchUniqueNamespace(f.UniqueName).
+				StartResourceRule().
+				MatchResource([]string{"apps"}, []string{"v1"}, []string{"deployments"}).
+				EndResourceRule().
+				WithValidation(admissionregistrationv1alpha1.Validation{
+					Expression:        "object.spec.replicas > 1",
+					MessageExpression: "'wants replicas > 1, got ' + object.spec.replicas",
+				}).
+				Build()
+			policy, err := client.AdmissionregistrationV1alpha1().ValidatingAdmissionPolicies().Create(ctx, policy, metav1.CreateOptions{})
+			framework.ExpectNoError(err, "create policy")
+			ginkgo.DeferCleanup(func(ctx context.Context, name string) error {
+				return client.AdmissionregistrationV1alpha1().ValidatingAdmissionPolicies().Delete(ctx, name, metav1.DeleteOptions{})
+			}, policy.Name)
+			binding := createBinding(f.UniqueName+".binding.example.com", f.UniqueName, policy.Name)
+			binding, err = client.AdmissionregistrationV1alpha1().ValidatingAdmissionPolicyBindings().Create(ctx, binding, metav1.CreateOptions{})
+			framework.ExpectNoError(err, "create policy binding")
+			ginkgo.DeferCleanup(func(ctx context.Context, name string) error {
+				return client.AdmissionregistrationV1alpha1().ValidatingAdmissionPolicyBindings().Delete(ctx, name, metav1.DeleteOptions{})
+			}, binding.Name)
+		})
+		ginkgo.By("waiting until the marker is denied", func() {
+			deployment := basicDeployment("marker-deployment", 1)
+			err := wait.PollUntilContextCancel(ctx, 100*time.Millisecond, true, func(ctx context.Context) (done bool, err error) {
+				_, err = client.AppsV1().Deployments(f.Namespace.Name).Create(ctx, deployment, metav1.CreateOptions{})
+				defer client.AppsV1().Deployments(f.Namespace.Name).Delete(ctx, deployment.Name, metav1.DeleteOptions{})
+				if err != nil {
+					if apierrors.IsInvalid(err) {
+						return true, nil
+					}
+					return false, err
+				}
+				return false, nil
+			})
+			framework.ExpectNoError(err, "wait for marker")
+		})
+		ginkgo.By("testing a replicated Deployment to be allowed", func() {
+			deployment := basicDeployment("replicated", 2)
+			deployment, err := client.AppsV1().Deployments(f.Namespace.Name).Create(ctx, deployment, metav1.CreateOptions{})
+			defer client.AppsV1().Deployments(f.Namespace.Name).Delete(ctx, deployment.Name, metav1.DeleteOptions{})
+			framework.ExpectNoError(err, "create replicated Deployment")
+		})
+		ginkgo.By("testing a non-replicated ReplicaSet not to be denied", func() {
+			replicaSet := basicReplicaSet("non-replicated", 1)
+			replicaSet, err := client.AppsV1().ReplicaSets(f.Namespace.Name).Create(ctx, replicaSet, metav1.CreateOptions{})
+			defer client.AppsV1().ReplicaSets(f.Namespace.Name).Delete(ctx, replicaSet.Name, metav1.DeleteOptions{})
+			framework.ExpectNoError(err, "create non-replicated ReplicaSet")
+		})
+	})
+})
+
+func createBinding(bindingName string, uniqueLabel string, policyName string) *admissionregistrationv1alpha1.ValidatingAdmissionPolicyBinding {
+	return &admissionregistrationv1alpha1.ValidatingAdmissionPolicyBinding{
+		ObjectMeta: metav1.ObjectMeta{Name: bindingName},
+		Spec: admissionregistrationv1alpha1.ValidatingAdmissionPolicyBindingSpec{
+			PolicyName: policyName,
+			MatchResources: &admissionregistrationv1alpha1.MatchResources{
+				NamespaceSelector: &metav1.LabelSelector{
+					MatchLabels: map[string]string{uniqueLabel: "true"},
+				},
+			},
+			ValidationActions: []admissionregistrationv1alpha1.ValidationAction{admissionregistrationv1alpha1.Deny},
+		},
+	}
+}
+
+func basicDeployment(name string, replicas int32) *appsv1.Deployment {
+	return &appsv1.Deployment{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:   name,
+			Labels: map[string]string{"app": "nginx"},
+		},
+		Spec: appsv1.DeploymentSpec{
+			Replicas: &replicas,
+			Selector: &metav1.LabelSelector{
+				MatchLabels: map[string]string{"app": "nginx"},
+			},
+			Template: v1.PodTemplateSpec{
+				ObjectMeta: metav1.ObjectMeta{
+					Labels: map[string]string{"app": "nginx"},
+				},
+				Spec: v1.PodSpec{
+					Containers: []v1.Container{
+						{
+							Name:  "nginx",
+							Image: "nginx:latest",
+						},
+					},
+				},
+			},
+		}}
+}
+
+func basicReplicaSet(name string, replicas int32) *appsv1.ReplicaSet {
+	return &appsv1.ReplicaSet{
+		ObjectMeta: metav1.ObjectMeta{
+			Name:   name,
+			Labels: map[string]string{"app": "nginx"},
+		},
+		Spec: appsv1.ReplicaSetSpec{
+			Replicas: &replicas,
+			Selector: &metav1.LabelSelector{
+				MatchLabels: map[string]string{"app": "nginx"},
+			},
+			Template: v1.PodTemplateSpec{
+				ObjectMeta: metav1.ObjectMeta{
+					Labels: map[string]string{"app": "nginx"},
+				},
+				Spec: v1.PodSpec{
+					Containers: []v1.Container{
+						{
+							Name:  "nginx",
+							Image: "nginx:latest",
+						},
+					},
+				},
+			},
+		}}
+}
+
+type validatingAdmissionPolicyBuilder struct {
+	policy *admissionregistrationv1alpha1.ValidatingAdmissionPolicy
+}
+
+type resourceRuleBuilder struct {
+	policyBuilder *validatingAdmissionPolicyBuilder
+	resourceRule  *admissionregistrationv1alpha1.NamedRuleWithOperations
+}
+
+func newValidatingAdmissionPolicyBuilder(policyName string) *validatingAdmissionPolicyBuilder {
+	return &validatingAdmissionPolicyBuilder{
+		policy: &admissionregistrationv1alpha1.ValidatingAdmissionPolicy{
+			ObjectMeta: metav1.ObjectMeta{Name: policyName},
+		},
+	}
+}
+
+func (b *validatingAdmissionPolicyBuilder) MatchUniqueNamespace(uniqueLabel string) *validatingAdmissionPolicyBuilder {
+	if b.policy.Spec.MatchConstraints == nil {
+		b.policy.Spec.MatchConstraints = &admissionregistrationv1alpha1.MatchResources{}
+	}
+	b.policy.Spec.MatchConstraints.NamespaceSelector = &metav1.LabelSelector{
+		MatchLabels: map[string]string{
+			uniqueLabel: "true",
+		},
+	}
+	return b
+}
+
+func (b *validatingAdmissionPolicyBuilder) StartResourceRule() *resourceRuleBuilder {
+	return &resourceRuleBuilder{
+		policyBuilder: b,
+		resourceRule: &admissionregistrationv1alpha1.NamedRuleWithOperations{
+			RuleWithOperations: admissionregistrationv1alpha1.RuleWithOperations{
+				Operations: []admissionregistrationv1.OperationType{admissionregistrationv1.Create, admissionregistrationv1.Update},
+				Rule: admissionregistrationv1alpha1.Rule{
+					APIGroups:   []string{"apps"},
+					APIVersions: []string{"v1"},
+					Resources:   []string{"deployments"},
+				},
+			},
+		},
+	}
+}
+
+func (rb *resourceRuleBuilder) CreateAndUpdate() *resourceRuleBuilder {
+	rb.resourceRule.Operations = []admissionregistrationv1.OperationType{admissionregistrationv1.Create, admissionregistrationv1.Update}
+	return rb
+}
+
+func (rb *resourceRuleBuilder) MatchResource(groups []string, versions []string, resources []string) *resourceRuleBuilder {
+	rb.resourceRule.Rule = admissionregistrationv1alpha1.Rule{
+		APIGroups:   groups,
+		APIVersions: versions,
+		Resources:   resources,
+	}
+	return rb
+}
+
+func (rb *resourceRuleBuilder) EndResourceRule() *validatingAdmissionPolicyBuilder {
+	b := rb.policyBuilder
+	if b.policy.Spec.MatchConstraints == nil {
+		b.policy.Spec.MatchConstraints = &admissionregistrationv1alpha1.MatchResources{}
+	}
+	b.policy.Spec.MatchConstraints.ResourceRules = append(b.policy.Spec.MatchConstraints.ResourceRules, *rb.resourceRule)
+	return b
+}
+
+func (b *validatingAdmissionPolicyBuilder) WithValidation(validation admissionregistrationv1alpha1.Validation) *validatingAdmissionPolicyBuilder {
+	b.policy.Spec.Validations = append(b.policy.Spec.Validations, validation)
+	return b
+}
+
+func (b *validatingAdmissionPolicyBuilder) Build() *admissionregistrationv1alpha1.ValidatingAdmissionPolicy {
+	return b.policy
+}