From 7cf7717d4c6612828a336d84158cd438d541fb7d Mon Sep 17 00:00:00 2001 From: Matt Liggett Date: Fri, 17 Jun 2016 11:38:53 -0700 Subject: [PATCH] Move the slow part of the test into a Slow block. --- test/e2e/federated-service.go | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/test/e2e/federated-service.go b/test/e2e/federated-service.go index 69987755270..80d08c53c2b 100644 --- a/test/e2e/federated-service.go +++ b/test/e2e/federated-service.go @@ -194,11 +194,9 @@ var _ = framework.KubeDescribe("Service [Feature:Federation]", func() { discoverService(f, name, true) } - // TODO(mml): Unclear how to make this meaningful and not terribly - // slow. How long (how many minutes?) do we verify that a given DNS - // lookup *doesn't* work before we call it a success? For now, - // commenting out. - /* + // TODO(mml): This currently takes 9 minutes. Consider reducing the + // TTL and/or running the pods in parallel. + Context("[Slow]", func() { localSvcDNSNames := []string{ FederatedServiceName, fmt.Sprintf("%s.%s", FederatedServiceName, f.Namespace.Name), @@ -207,7 +205,7 @@ var _ = framework.KubeDescribe("Service [Feature:Federation]", func() { for _, name := range localSvcDNSNames { discoverService(f, name, false) } - */ + }) }) }) })