From 962e7534b4ee9df96d88883138fa958451972910 Mon Sep 17 00:00:00 2001 From: "Dr. Stefan Schimanski" Date: Fri, 9 Sep 2016 15:51:12 +0200 Subject: [PATCH] Only set sysctls for infra containers --- pkg/kubelet/dockertools/docker_manager.go | 24 ++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/pkg/kubelet/dockertools/docker_manager.go b/pkg/kubelet/dockertools/docker_manager.go index 90ece063cc6..c8945f20f51 100644 --- a/pkg/kubelet/dockertools/docker_manager.go +++ b/pkg/kubelet/dockertools/docker_manager.go @@ -687,18 +687,20 @@ func (dm *DockerManager) runContainer( } // Set sysctls if requested - sysctls, unsafeSysctls, err := api.SysctlsFromPodAnnotations(pod.Annotations) - if err != nil { - dm.recorder.Eventf(ref, api.EventTypeWarning, events.FailedToCreateContainer, "Failed to create docker container %q of pod %q with error: %v", container.Name, format.Pod(pod), err) - return kubecontainer.ContainerID{}, err - } - if len(sysctls)+len(unsafeSysctls) > 0 { - hc.Sysctls = make(map[string]string, len(sysctls)+len(unsafeSysctls)) - for _, c := range sysctls { - hc.Sysctls[c.Name] = c.Value + if container.Name == PodInfraContainerName { + sysctls, unsafeSysctls, err := api.SysctlsFromPodAnnotations(pod.Annotations) + if err != nil { + dm.recorder.Eventf(ref, api.EventTypeWarning, events.FailedToCreateContainer, "Failed to create docker container %q of pod %q with error: %v", container.Name, format.Pod(pod), err) + return kubecontainer.ContainerID{}, err } - for _, c := range unsafeSysctls { - hc.Sysctls[c.Name] = c.Value + if len(sysctls)+len(unsafeSysctls) > 0 { + hc.Sysctls = make(map[string]string, len(sysctls)+len(unsafeSysctls)) + for _, c := range sysctls { + hc.Sysctls[c.Name] = c.Value + } + for _, c := range unsafeSysctls { + hc.Sysctls[c.Name] = c.Value + } } }