github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 09:22:44 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #51616 from tcharding/golint-kc-secret-for-tls

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 49971, 51357, 51616, 51649, 51372)

kubectl: Remove ending punctuation from error strings

**What this PR does / why we need it**:

`golint` emits 2 warnings of type:

`error strings should not end with punctuation`

Remove punctuation from end of error strings.



**Release note**:

```release-note
NONE
```
/sig cli
/kind cleanup
This commit is contained in:
Kubernetes Submit Queue 2017-09-01 01:12:42 -07:00 committed by GitHub
commit 7d49e7bb17
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/kubectl/secret_for_tls.go
View File

@ -128,10 +128,10 @@ func (s SecretForTLSGeneratorV1) validate() error {
// if no key/cert is given. The only requiredment is that we either get both // if no key/cert is given. The only requiredment is that we either get both
// or none. See test/e2e/ingress_utils for self signed cert generation. // or none. See test/e2e/ingress_utils for self signed cert generation.
if len(s.Key) == 0 { if len(s.Key) == 0 {
return fmt.Errorf("key must be specified.") return fmt.Errorf("key must be specified")
} }
if len(s.Cert) == 0 { if len(s.Cert) == 0 {
return fmt.Errorf("certificate must be specified.") return fmt.Errorf("certificate must be specified")
} }
if _, err := tls.LoadX509KeyPair(s.Cert, s.Key); err != nil { if _, err := tls.LoadX509KeyPair(s.Cert, s.Key); err != nil {
return fmt.Errorf("failed to load key pair %v", err) return fmt.Errorf("failed to load key pair %v", err)