github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-07 12:11:43 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #88414 from tanjunchen/resole-TODO

Browse Source 
test/e2e/:resolve pending TODO: write a wrapper for ExpectNoErrorWithOffset()
This commit is contained in:
Kubernetes Prow Robot
2020-03-04 20:12:50 -08:00
committed by GitHub
parent ac32644d6e b5cdb6e6cb
commit 7d6d790b43
6 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test/e2e/apps/daemon_restart.go
View File

@@ -311,7 +311,6 @@ var _ = SIGDescribe("DaemonRestart [Disruptive]", func() {
if err != nil { if err != nil {
framework.Logf("Unexpected error occurred: %v", err) framework.Logf("Unexpected error occurred: %v", err)
} }
// TODO: write a wrapper for ExpectNoErrorWithOffset()
framework.ExpectNoErrorWithOffset(0, err) framework.ExpectNoErrorWithOffset(0, err)
preRestarts, badNodes := getContainerRestarts(f.ClientSet, ns, labelSelector) preRestarts, badNodes := getContainerRestarts(f.ClientSet, ns, labelSelector)
if preRestarts != 0 { if preRestarts != 0 {

1
test/e2e/autoscaling/cluster_size_autoscaling.go
View File

@@ -1241,7 +1241,6 @@ func getPoolNodes(f *framework.Framework, poolName string) []*v1.Node {
if err != nil { if err != nil {
framework.Logf("Unexpected error occurred: %v", err) framework.Logf("Unexpected error occurred: %v", err)
} }
// TODO: write a wrapper for ExpectNoErrorWithOffset()
framework.ExpectNoErrorWithOffset(0, err) framework.ExpectNoErrorWithOffset(0, err)
for _, node := range nodeList.Items { for _, node := range nodeList.Items {
if node.Labels[gkeNodepoolNameKey] == poolName { if node.Labels[gkeNodepoolNameKey] == poolName {

1
test/e2e/cloud/nodes.go
View File

@@ -52,7 +52,6 @@ var _ = SIGDescribe("[Feature:CloudProvider][Disruptive] Nodes", func() {
if err != nil { if err != nil {
framework.Logf("Unexpected error occurred: %v", err) framework.Logf("Unexpected error occurred: %v", err)
} }
// TODO: write a wrapper for ExpectNoErrorWithOffset()
framework.ExpectNoErrorWithOffset(0, err) framework.ExpectNoErrorWithOffset(0, err)
framework.Logf("Original number of ready nodes: %d", len(origNodes.Items)) framework.Logf("Original number of ready nodes: %d", len(origNodes.Items))

1
test/e2e/scheduling/predicates.go
View File

@@ -106,7 +106,6 @@ var _ = SIGDescribe("SchedulerPredicates [Serial]", func() {
framework.Logf("Unexpected error occurred: %v", err) framework.Logf("Unexpected error occurred: %v", err)
} }
// TODO: write a wrapper for ExpectNoErrorWithOffset()
framework.ExpectNoErrorWithOffset(0, err) framework.ExpectNoErrorWithOffset(0, err)
err = framework.CheckTestingNSDeletedExcept(cs, ns) err = framework.CheckTestingNSDeletedExcept(cs, ns)

1
test/e2e/scheduling/preemption.go
View File

@@ -92,7 +92,6 @@ var _ = SIGDescribe("SchedulerPreemption [Serial]", func() {
if err != nil { if err != nil {
framework.Logf("Unexpected error occurred: %v", err) framework.Logf("Unexpected error occurred: %v", err)
} }
// TODO: write a wrapper for ExpectNoErrorWithOffset()
framework.ExpectNoErrorWithOffset(0, err) framework.ExpectNoErrorWithOffset(0, err)
err = framework.CheckTestingNSDeletedExcept(cs, ns) err = framework.CheckTestingNSDeletedExcept(cs, ns)

1
test/e2e/scheduling/priorities.go
View File

@@ -148,7 +148,6 @@ var _ = SIGDescribe("SchedulerPriorities [Serial]", func() {
if err != nil { if err != nil {
framework.Logf("Unexpected error occurred: %v", err) framework.Logf("Unexpected error occurred: %v", err)
} }
// TODO: write a wrapper for ExpectNoErrorWithOffset()
framework.ExpectNoErrorWithOffset(0, err) framework.ExpectNoErrorWithOffset(0, err)
err = framework.CheckTestingNSDeletedExcept(cs, ns) err = framework.CheckTestingNSDeletedExcept(cs, ns)