github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-23 19:56:01 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #38440 from justinsb/conversion_gen_safe_at_some_speeds

Browse Source 
Automatic merge from submit-queue

conversion-gen: add --skip-unsafe flag

We should expose the SkipUnsafe option, for legacy compatability, so
that conversion-go can be used in other projects, and for platforms
where unsafe is not available.

Make unsafe code generation the default though, and have the help text
hint that the resulting code is sub-optimal.
This commit is contained in:
Kubernetes Submit Queue 2016-12-18 09:16:16 -08:00 committed by GitHub
commit 7e1cacaa91
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/libs/go2idl/conversion-gen/main.go
View File

@ -64,6 +64,8 @@ func main() {
} }
pflag.CommandLine.StringSliceVar(&customArgs.ExtraPeerDirs, "extra-peer-dirs", customArgs.ExtraPeerDirs, pflag.CommandLine.StringSliceVar(&customArgs.ExtraPeerDirs, "extra-peer-dirs", customArgs.ExtraPeerDirs,
"Comma-separated list of import paths which are considered, after tag-specified peers, for conversions.") "Comma-separated list of import paths which are considered, after tag-specified peers, for conversions.")
pflag.CommandLine.BoolVar(&customArgs.SkipUnsafe, "skip-unsafe", customArgs.SkipUnsafe,
"If true, will not generate code using unsafe pointer conversions; resulting code may be slower.")
arguments.CustomArgs = customArgs arguments.CustomArgs = customArgs
// Run it. // Run it.

1
hack/verify-flags/known-flags.txt
View File

@ -568,6 +568,7 @@ since-time
skip-generated-rewrite skip-generated-rewrite
skip-munges skip-munges
skip-preflight-checks skip-preflight-checks
skip-unsafe
sort-by sort-by
source-file source-file
ssh-env ssh-env