From b886b9b1085bb6a12c7a850ca769c9ab3155d92b Mon Sep 17 00:00:00 2001 From: "menglong.qi" Date: Wed, 17 Nov 2021 09:22:57 +0800 Subject: [PATCH 1/2] fix: typo --- pkg/kubelet/eviction/eviction_manager.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/kubelet/eviction/eviction_manager.go b/pkg/kubelet/eviction/eviction_manager.go index a943e0a1ab5..f905ae07983 100644 --- a/pkg/kubelet/eviction/eviction_manager.go +++ b/pkg/kubelet/eviction/eviction_manager.go @@ -63,7 +63,7 @@ type managerImpl struct { config Config // the function to invoke to kill a pod killPodFunc KillPodFunc - // the function to get the mirror pod by a given statid pod + // the function to get the mirror pod by a given static pod mirrorPodFunc MirrorPodFunc // the interface that knows how to do image gc imageGC ImageGC From 12eff56460d30bbf236ade75021d57efc41e01dc Mon Sep 17 00:00:00 2001 From: "menglong.qi" Date: Sun, 28 Nov 2021 17:21:29 +0800 Subject: [PATCH 2/2] fix: syncPod outdated workflow comment --- pkg/kubelet/kubelet.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/kubelet/kubelet.go b/pkg/kubelet/kubelet.go index f174235d262..285e2a0299f 100644 --- a/pkg/kubelet/kubelet.go +++ b/pkg/kubelet/kubelet.go @@ -1516,6 +1516,7 @@ func (kl *Kubelet) Run(updates <-chan kubetypes.PodUpdate) { // o - the SyncPodOptions for this invocation // // The workflow is: +// * Kill the pod immediately if update type is SyncPodKill // * If the pod is being created, record pod worker start latency // * Call generateAPIPodStatus to prepare an v1.PodStatus for the pod // * If the pod is being seen as running for the first time, record pod @@ -1742,7 +1743,7 @@ func (kl *Kubelet) syncPod(ctx context.Context, updateType kubetypes.SyncPodType for _, r := range result.SyncResults { if r.Error != kubecontainer.ErrCrashLoopBackOff && r.Error != images.ErrImagePullBackOff { // Do not record an event here, as we keep all event logging for sync pod failures - // local to container runtime so we get better errors + // local to container runtime, so we get better errors. return err } }