github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 22:17:14 +00:00
Code Issues Projects Releases Wiki Activity

Fix nil panic in vsphere tests

Browse Source 
During test cleanup, we iterate over nodes.Items, but if test fails
during setup, nodes may be nil.
This commit is contained in:
Jonathan Basseri 2020-03-17 12:09:45 -07:00
parent 426e5dc57d
commit 7f17ef28a8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/e2e/storage/vsphere/vsphere_scale.go
View File

@ -23,7 +23,7 @@ import (
"github.com/onsi/ginkgo" "github.com/onsi/ginkgo"
"github.com/onsi/gomega" "github.com/onsi/gomega"
"k8s.io/api/core/v1" v1 "k8s.io/api/core/v1"
storagev1 "k8s.io/api/storage/v1" storagev1 "k8s.io/api/storage/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
clientset "k8s.io/client-go/kubernetes" clientset "k8s.io/client-go/kubernetes"
@ -108,7 +108,7 @@ var _ = utils.SIGDescribe("vcp at scale [Feature:vsphere] ", func() {
*/ */
framework.AddCleanupAction(func() { framework.AddCleanupAction(func() {
// Cleanup actions will be called even when the tests are skipped and leaves namespace unset. // Cleanup actions will be called even when the tests are skipped and leaves namespace unset.
if len(namespace) > 0 { if len(namespace) > 0 && nodes != nil {
for _, node := range nodes.Items { for _, node := range nodes.Items {
framework.RemoveLabelOffNode(client, node.Name, NodeLabelKey) framework.RemoveLabelOffNode(client, node.Name, NodeLabelKey)
} }