From 7f53f7649e178622ad1a64988913f025399f152b Mon Sep 17 00:00:00 2001 From: Stephen Kitt Date: Thu, 13 Jul 2023 12:02:26 +0200 Subject: [PATCH] Use intstr.Parse instead of reimplementing it Signed-off-by: Stephen Kitt --- staging/src/k8s.io/kubectl/pkg/cmd/expose/expose.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/staging/src/k8s.io/kubectl/pkg/cmd/expose/expose.go b/staging/src/k8s.io/kubectl/pkg/cmd/expose/expose.go index 9721dc3cfe6..1bec0e91278 100644 --- a/staging/src/k8s.io/kubectl/pkg/cmd/expose/expose.go +++ b/staging/src/k8s.io/kubectl/pkg/cmd/expose/expose.go @@ -532,12 +532,7 @@ func (o *ExposeServiceOptions) createService() (*corev1.Service, error) { } targetPortString := o.TargetPort if len(targetPortString) > 0 { - var targetPort intstr.IntOrString - if portNum, err := strconv.Atoi(targetPortString); err != nil { - targetPort = intstr.FromString(targetPortString) - } else { - targetPort = intstr.FromInt(portNum) - } + targetPort := intstr.Parse(targetPortString) // Use the same target-port for every port for i := range service.Spec.Ports { service.Spec.Ports[i].TargetPort = targetPort